Review main Merged

85641[TASK] Dissolve ext:form AbstractBackendController

Christian Kuhn CR +2 V +2 Expert +758 −768 updated 08/15/24, 12:42

Commit message

AbstractBackendController of ext:form does not do
much, except it gets DI wrong and relies on the
global initializeObject method, which is kinda ugly
for stuff like this.

The patch merges AbstractBackendController into the
two ext:form backend controllers, which now extend
extbase ActionController directly. The patch finishes
DI of the two controllers and cleans up minor things
like the usual "use less properties by handing over
stuff directly" stuff.

The existing tests receive a rewrite and are changed
from unit to functional tests: This reduces mocking
significantly and makes much more clear what is
actually tested. The should be much more easy to
maintain now.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 712

  1. Christian Kuhn uploaded patch set 1 08/14/24, 23:08

  2. core-ci voted on patch set 1 V -1 08/14/24, 23:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63425

  3. Christian Kuhn uploaded patch set 2 V -1 08/15/24, 09:13

  4. core-ci voted on patch set 2 V -1 08/15/24, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63459

  5. core-ci commented on patch set 2 08/15/24, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63459

  6. Christian Kuhn uploaded patch set 3 V -1 08/15/24, 11:26

  7. core-ci voted on patch set 3 V -1 08/15/24, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63471

  8. Christian Kuhn uploaded patch set 4 V -1 08/15/24, 12:09

  9. core-ci voted on patch set 4 V +1 08/15/24, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63477

  10. Stefan Bürk voted on patch set 4 CR +1 V +1 08/15/24, 12:24

  11. Anja Leichsenring voted on patch set 4 CR +2 V +2 08/15/24, 12:38

  12. Anja Leichsenring merged patch set 5 08/15/24, 12:42