Review main Merged

85642[TASK] Revert "[BUGFIX] Replace hardcoded attributes for <span> tags"

Oliver Hader CR +2 V +2 Easy +7 −18 updated 08/15/24, 10:01

Commit message

The previous patch introduced ambiguities for allowed attributes
for multiple HTML elements that were reliable and hard-coded in
previous versions.

This reverts commit cb5f8bb4f513c74dccfb7490bbd50f865ca50e04.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1

Issues 1

Files 1

Review log 712

  1. Oliver Hader uploaded patch set 1 08/15/24, 08:18

  2. core-ci voted on patch set 1 V -1 08/15/24, 08:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63446

  3. core-ci commented on patch set 1 08/15/24, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63446

  4. core-ci commented on patch set 1 08/15/24, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63446

  5. core-ci commented on patch set 1 08/15/24, 08:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63446

  6. Oliver Hader uploaded patch set 2 08/15/24, 09:08

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  7. core-ci voted on patch set 2 V -1 08/15/24, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63458

  8. Benjamin Franzke commented on patch set 2 CR +1 V +1 08/15/24, 09:49

    Needs to be delayed until doctrine dbal patch is merged: > 85620: [TASK] Raise `doctrine/dbal:^4.1` | https://review.typo3.org/c/Packages/TYPO3.CMS/+/85620
  9. Oliver Hader wrote 08/15/24, 09:57

    Removed Verified-1 by core-ci
  10. Oliver Hader commented on patch set 2 08/15/24, 09:57

    Removed CI vote due to doctrine/dbal 4.0.2 → 4.1.0 changed property names
  11. Oliver Hader voted on patch set 2 CR +2 V +2 08/15/24, 10:00

  12. Oliver Hader merged patch set 3 08/15/24, 10:01