Review 12.4 Merged

85643[TASK] Revert "[BUGFIX] Replace hardcoded attributes for <span> tags"

Oliver Hader CR +2 V +2 Easy +7 −18 updated 08/15/24, 10:01

Commit message

The previous patch introduced ambiguities for allowed attributes
for multiple HTML elements that were reliable and hard-coded in
previous versions.

This reverts commit 71c9e1906c09ddea7931e844c88e1255c29a2a82.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 58

  1. Oliver Hader uploaded patch set 1 08/15/24, 08:18

  2. core-ci voted on patch set 1 V +1 08/15/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63447

  3. Oliver Hader updated the commit message in patch set 2 V +1 08/15/24, 09:07

  4. core-ci voted on patch set 2 V -1 08/15/24, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63457

  5. core-ci voted on patch set 2 V +1 08/15/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63457

  6. Benjamin Franzke voted on patch set 2 CR +1 V +1 08/15/24, 09:48

  7. Oliver Hader voted on patch set 2 CR +2 V +2 08/15/24, 10:00

  8. Oliver Hader merged patch set 3 08/15/24, 10:01