Review main Merged

85652[TASK] Rename web component 'typo3-formengine-element-select-check-box'

Jasmina Ließmann CR +2 V +2 Normal +24 −28 updated 08/16/24, 09:09

Commit message

The functionality of the web component `<typo3-formengine-element-
select-check-box></typo3-formengine-element-select-check-box>`
should not be exclusively for use in FormEngine. Therefore, the
component is renamed and moved.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 1624

  1. Jasmina Ließmann uploaded patch set 1 08/15/24, 14:35

  2. Jasmina Ließmann updated the commit message in patch set 2 08/15/24, 14:38

  3. core-ci voted on patch set 1 V -1 08/15/24, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63500

  4. Jasmina Ließmann uploaded patch set 3 08/15/24, 14:43

  5. Andreas Kienast voted on patch set 3 CR +1 08/15/24, 14:47

  6. core-ci voted on patch set 2 V -1 08/15/24, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63501

  7. core-ci voted on patch set 3 V -1 08/15/24, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63504

  8. Jasmina Ließmann uploaded patch set 4 CR +1 V -1 08/15/24, 15:03

  9. core-ci voted on patch set 4 V +1 08/15/24, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63509

  10. Christian Kuhn voted on patch set 4 CR +1 V +1 08/15/24, 18:09

  11. Oli Bartsch uploaded patch set 5 CR +1 V +1 08/16/24, 08:21

  12. Oli Bartsch voted on patch set 5 CR +1 V +1 08/16/24, 08:22

  13. Stefan Bürk voted on patch set 5 CR +1 V +1 08/16/24, 08:27

  14. core-ci voted on patch set 5 V -1 08/16/24, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63560

  15. core-ci voted on patch set 5 V +1 08/16/24, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63560

  16. Jasmina Ließmann voted on patch set 5 CR -1 08/16/24, 08:36

  17. Jasmina Ließmann uploaded patch set 6 CR +1 V +1 08/16/24, 08:47

  18. Oli Bartsch commented on patch set 6 CR +1 V +1 08/16/24, 08:50

    SelectCheckBoxElement.php:176

    Thanks 👍
  19. Jasmina Ließmann commented on patch set 6 08/16/24, 08:50

    I removed another obsolete CSS class in SelectCheckBoxElement.php.
  20. Christian Kuhn voted on patch set 6 CR +1 V +1 08/16/24, 08:51

  21. core-ci voted on patch set 6 V -1 08/16/24, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63563

  22. core-ci voted on patch set 6 V +1 08/16/24, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63563

  23. Jasmina Ließmann voted on patch set 6 CR +2 V +2 08/16/24, 09:09

  24. Jasmina Ließmann merged patch set 7 08/16/24, 09:09