Review main Merged

85654[TASK] Make ext:form ConfigurationService stateless

Christian Kuhn CR +2 V +2 Expert +712 −1016 updated 08/16/24, 08:44

Commit message

Refactor ext:form ConfigurationService towards DI.
The main FormFrontendController is refactored
along the way. Both their test cases are turned
into functional tests, to other tests are adapted
slightly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1016

  1. Christian Kuhn uploaded patch set 1 08/15/24, 15:23

  2. core-ci voted on patch set 1 V -1 08/15/24, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63514

  3. Christian Kuhn uploaded patch set 2 V -1 08/15/24, 20:54

  4. core-ci voted on patch set 2 V -1 08/15/24, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63523

  5. Christian Kuhn uploaded patch set 3 V -1 08/15/24, 21:36

  6. core-ci voted on patch set 3 V -1 08/15/24, 21:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63524

  7. Christian Kuhn uploaded patch set 4 V -1 08/15/24, 22:16

  8. core-ci voted on patch set 4 V -1 08/15/24, 22:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63525

  9. Christian Kuhn uploaded patch set 5 V -1 08/15/24, 22:41

  10. Christian Kuhn updated the commit message in patch set 6 08/15/24, 22:47

  11. core-ci voted on patch set 5 V +1 08/15/24, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63526

  12. core-ci voted on patch set 6 V +1 08/15/24, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63527

  13. Anja Leichsenring voted on patch set 6 CR +1 V +1 08/16/24, 07:03

  14. Stefan Bürk voted on patch set 6 CR +1 V +1 08/16/24, 07:26

  15. Christian Kuhn voted on patch set 6 CR +2 V +2 08/16/24, 08:43

  16. Christian Kuhn merged patch set 7 08/16/24, 08:44