85654[TASK] Make ext:form ConfigurationService stateless
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 7
- Build/phpstan/phpstan-baseline.neon+0 −10
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+13 −38
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+54 −115
- typo3/sysext/form/Tests/Functional/Controller/FormFrontendControllerTest.phprenamed+48 −48
- typo3/sysext/form/Tests/Functional/Domain/Configuration/ConfigurationServiceTest.phprenamed+562 −776
- typo3/sysext/form/Tests/Functional/Domain/Model/Renderable/AbstractRenderableTest.php+20 −26
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionValidationServiceTest.php+15 −3
Review log 1016
-
Christian Kuhn uploaded patch set 1 08/15/24, 15:23
-
core-ci voted on patch set 1 V -1 08/15/24, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63514
-
Christian Kuhn uploaded patch set 2
V -108/15/24, 20:54 -
core-ci voted on patch set 2 V -1 08/15/24, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63523
-
Christian Kuhn uploaded patch set 3
V -108/15/24, 21:36 -
core-ci voted on patch set 3 V -1 08/15/24, 21:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63524
-
Christian Kuhn uploaded patch set 4
V -108/15/24, 22:16 -
core-ci voted on patch set 4 V -1 08/15/24, 22:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63525
-
Christian Kuhn uploaded patch set 5
V -108/15/24, 22:41 -
Christian Kuhn updated the commit message in patch set 6 08/15/24, 22:47
-
core-ci voted on patch set 5 V +1 08/15/24, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63526
-
core-ci voted on patch set 6 V +1 08/15/24, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63527
-
Anja Leichsenring voted on patch set 6 CR +1 V +1 08/16/24, 07:03
-
Stefan Bürk voted on patch set 6 CR +1 V +1 08/16/24, 07:26
-
Christian Kuhn voted on patch set 6 CR +2 V +2 08/16/24, 08:43
-
Christian Kuhn merged patch set 7 08/16/24, 08:44