Review main Merged

85659[BUGFIX] Allow "group" filter without "parameters"

Mathias Brodala CR +2 V +2 Easy +1 −1 updated 09/09/24, 09:40

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Mathias Brodala uploaded patch set 1 08/16/24, 13:57

  2. core-ci voted on patch set 1 V -1 08/16/24, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63586

  3. core-ci voted on patch set 1 V +1 08/16/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63586

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/04/24, 09:48

  5. Garvin Hicking commented on patch set 1 CR +1 V +1 09/04/24, 09:55

    (Took me some time, I wanted to check the other 97 instances of the core where "?: []" is used and if that might need an adjustment too; but I don't think so)
  6. Benni Mack voted on patch set 1 CR +1 09/04/24, 12:39

  7. Garvin Hicking voted on patch set 1 CR +2 V +2 09/09/24, 09:40

  8. Garvin Hicking merged patch set 2 09/09/24, 09:40