Review main Merged

85660[TASK] Use DI in ext:form FormDefinitionValidationService

Christian Kuhn CR +2 V +2 Expert +432 −713 updated 08/16/24, 18:31

Commit message

The patch is rather straight in class
`FormDefinitionValidationService`. The tests
receive a major overhaul towards less mocking.

Note the entire ext:form 'validation' topic is
rather over-abstracted and complex. It should
see some simplifications in the future.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1016

  1. Christian Kuhn uploaded patch set 1 08/16/24, 15:42

  2. core-ci voted on patch set 1 V -1 08/16/24, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63588

  3. Christian Kuhn uploaded patch set 2 V -1 08/16/24, 17:48

  4. core-ci voted on patch set 2 V -1 08/16/24, 17:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63591

  5. Christian Kuhn uploaded patch set 3 V -1 08/16/24, 18:06

  6. Christian Kuhn updated the commit message in patch set 4 08/16/24, 18:11

  7. core-ci voted on patch set 3 V -1 08/16/24, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63592

  8. Christian Kuhn uploaded patch set 5 08/16/24, 18:16

  9. core-ci voted on patch set 4 V -1 08/16/24, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63593

  10. Christian Kuhn updated the commit message in patch set 6 08/16/24, 18:20

  11. core-ci voted on patch set 5 V +1 08/16/24, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63594

  12. Stefan Bürk voted on patch set 6 CR +1 V +1 08/16/24, 18:22

  13. Anja Leichsenring voted on patch set 6 CR +2 V +2 08/16/24, 18:26

  14. core-ci voted on patch set 6 V +1 08/16/24, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63595

  15. Christian Kuhn voted on patch set 6 CR +2 V +2 08/16/24, 18:31

  16. Christian Kuhn merged patch set 7 08/16/24, 18:31