85660[TASK] Use DI in ext:form FormDefinitionValidationService
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionValidationService.php+17 −29
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinitionValidationServiceTest.phpnew+363 −0
- typo3/sysext/form/Tests/Functional/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.phprenamed+52 −78
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionValidationServiceTest.phpdeleted+0 −606
Review log 1016
-
Christian Kuhn uploaded patch set 1 08/16/24, 15:42
-
core-ci voted on patch set 1 V -1 08/16/24, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63588
-
Christian Kuhn uploaded patch set 2
V -108/16/24, 17:48 -
core-ci voted on patch set 2 V -1 08/16/24, 17:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63591
-
Christian Kuhn uploaded patch set 3
V -108/16/24, 18:06 -
Christian Kuhn updated the commit message in patch set 4 08/16/24, 18:11
-
core-ci voted on patch set 3 V -1 08/16/24, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63592
-
Christian Kuhn uploaded patch set 5 08/16/24, 18:16
-
core-ci voted on patch set 4 V -1 08/16/24, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63593
-
Christian Kuhn updated the commit message in patch set 6 08/16/24, 18:20
-
core-ci voted on patch set 5 V +1 08/16/24, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63594
-
Stefan Bürk voted on patch set 6 CR +1 V +1 08/16/24, 18:22
-
Anja Leichsenring voted on patch set 6 CR +2 V +2 08/16/24, 18:26
-
core-ci voted on patch set 6 V +1 08/16/24, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63595
-
Christian Kuhn voted on patch set 6 CR +2 V +2 08/16/24, 18:31
-
Christian Kuhn merged patch set 7 08/16/24, 18:31