Review main Merged

85662[TASK] Deprecate instantiation of IconRegistry in ext_localconf.php

Nikita Hovratov CR +2 V +2 Normal +91 −3 updated 08/30/24, 17:20

Commit message

Nowadays, it is not needed anymore to manually call IconRegistry
to register icons. Since TYPO3 v11 we have the Configuration/Icons.php
file, which should be enough for most use cases.

This deprecation gives extension authors incentive to clean their
ext_localconf.php files.

Some background: This has become problematic with Content Blocks, as
it uses service provider extension method to dynamically register icons.
However, when other extensions instantiate IconRegistry in
ext_localconf.php the WHOLE Content Blocks compiling is triggered at an
early stage of bootstrapping, when TCA is not even available yet. This
does not work and forces us to use a less clean method by listening to
the BootstrapComplete event.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Torben Hansen +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Torben Hansen +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1319

  1. Nikita Hovratov uploaded patch set 1 08/16/24, 19:36

  2. Nikita Hovratov commented on patch set 1 08/16/24, 19:37

    Thoughts? If accepted, I provide a proper Deprecation rst.
  3. core-ci voted on patch set 1 V -1 08/16/24, 19:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63598

  4. Nikita Hovratov uploaded patch set 2 V -1 08/29/24, 17:58

  5. Nikita Hovratov uploaded patch set 3 08/29/24, 18:02

  6. Nikita Hovratov uploaded patch set 4 08/29/24, 18:10

  7. core-ci voted on patch set 2 V +1 08/29/24, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64489

  8. core-ci voted on patch set 3 V +1 08/29/24, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64491

  9. core-ci voted on patch set 4 V +1 08/29/24, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64492

  10. Nikita Hovratov uploaded patch set 5 V +1 08/29/24, 18:32

  11. core-ci voted on patch set 5 V +1 08/29/24, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64493

  12. Simon Praetorius voted on patch set 5 CR +1 V +1 08/29/24, 21:16

  13. Torben Hansen voted on patch set 5 CR +1 V +1 08/30/24, 06:36

  14. Stefan Bürk commented on patch set 6 CR +1 V +1 08/30/24, 17:02

    Published edit on patch set 5.
  15. Simon Praetorius voted on patch set 6 CR +1 V +1 08/30/24, 17:03

  16. Torben Hansen voted on patch set 6 CR +1 V +1 08/30/24, 17:04

  17. core-ci voted on patch set 6 V +1 08/30/24, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64540

  18. Stefan Bürk voted on patch set 6 CR +2 V +2 08/30/24, 17:20

  19. Stefan Bürk merged patch set 7 08/30/24, 17:20