85663[DOCS] Document "Enable recycler by default"
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Chris Müller +1
- Stefan Bürk +1
-
Verified V +2 Done
- Garvin Hicking +2
- Chris Müller +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1924
-
Lina Wolf uploaded patch set 1 08/17/24, 07:25
-
core-ci voted on patch set 1 V +1 08/17/24, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63612
-
Garvin Hicking voted on patch set 1 CR +1 V +1 08/17/24, 07:58
-
Christian Kuhn commented on patch set 1 08/17/24, 10:01
We're talking about non-composer "legacy" instances here, as far as I understand: With composer, ext:recycler is *not* an automatic dependency and still needs to be 'composer require'd. The change was just that ext:recycler is loaded by default for non-composer instances doing a fresh installation. Maybe the change could have slight rewording to reflect this difference a bit more precisely, or do you think its good enough already? -
Lina Wolf commented on patch set 1 08/17/24, 10:35
Reply
See https://review.typo3.org/c/Packages/TYPO3.CMS/+/85472/3/typo3/sysext/core/Documentation/Changelog/13.3/Feature-99418-EnableRecyclerByDefault.rst#19 New composer-based TYPO3 installations based on the TYPO3 CMS Base Distribution, and new "classic mode" (tarball / zip download) installations have the core extension `recycler` enabled by default. -
Stefan Bürk commented on patch set 1 08/17/24, 11:02
Reply
Using base distribution is not ensured. I'd say many agencies will not use it at all and require core packges manually for composer mode instances. That should be at least stated precise here and not talking about new composer based instances in general. Otherwise this is misleading and not correct in all cases. -
Lina Wolf commented on patch set 2
CR +1V +108/17/24, 11:19Published edit on patch set 1. -
Lina Wolf commented on patch set 2 08/17/24, 11:20
Reply
I rephrased it. -
core-ci voted on patch set 2 V +1 08/17/24, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63644
-
Garvin Hicking commented on patch set 2 08/17/24, 13:36
Good catch. There's a stray whitespace after "new" in the versionchanged box; otherwise this would work for me... -
Lina Wolf commented on patch set 3
V +108/17/24, 13:39Published edit on patch set 2. -
core-ci voted on patch set 3 V -1 08/17/24, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63660
-
core-ci voted on patch set 3 V +1 08/17/24, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63660
-
Chris Müller commented on patch set 3 08/17/24, 14:23
Index.rst:8should be "Recycler" as in the case it is a proper name.Index.rst:13As Composer is a proper name, this should be uppercase: "Composer-based".Index.rst:19Here tooIndex.rst:20zip -> ZIP (see also: https://en.wikipedia.org/wiki/ZIP_(file_format)) -
Lina Wolf commented on patch set 4
V +108/18/24, 05:34Published edit on patch set 3. -
Lina Wolf commented on patch set 4 08/18/24, 05:34
Index.rst:8ReplyDoneIndex.rst:13ReplyDoneIndex.rst:19ReplyDoneIndex.rst:20ReplyDone -
Lina Wolf commented on patch set 4 08/18/24, 05:34
Reply
Done -
core-ci voted on patch set 4 V +1 08/18/24, 05:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63690
-
Chris Müller voted on patch set 4 CR +1 08/18/24, 06:32
-
Chris Müller voted on patch set 4 V +1 08/18/24, 06:46
-
Garvin Hicking commented on patch set 4 CR +1 V +1 08/18/24, 08:50
@lolli@schwarzbu.ch @stefan@buerk.tech Are your issues resolved properly? Waiting with merge. -
Stefan Bürk voted on patch set 4 CR +1 V +1 08/19/24, 08:41
-
Garvin Hicking voted on patch set 4 CR +2 V +2 08/19/24, 15:30
-
Garvin Hicking merged patch set 5 08/19/24, 15:30