85664[DOCS] Document base64 attribute of f:image
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
-
Verified V +2 Done
- Garvin Hicking +2
Issues 2
Files 1
Review log 1726
Show 01 earlier messages
-
TYPO3com uploaded patch set 1 08/17/24, 07:42
-
core-ci voted on patch set 1 V -1 08/17/24, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63613
-
Lina Wolf commented on patch set 2
V -108/17/24, 07:55Published edit on patch set 1. -
Lina Wolf commented on patch set 3 08/17/24, 07:59
Published edit on patch set 2. -
Garvin Hicking commented on patch set 2 08/17/24, 08:01
ImageViewHelper.php:112are these tabs here appropriate or need be whitespace?ImageViewHelper.php:161Once base64 and once Base64, we should unify this?ImageViewHelper.php:161have you tested if emails really work with base64 encode? I think recommending this requires to make sure major mail clients all support this...? -
Lina Wolf commented on patch set 4 08/17/24, 08:05
Published edit on patch set 3. -
Lina Wolf commented on patch set 4 08/17/24, 08:05
ImageViewHelper.php:112ReplyDoneImageViewHelper.php:161ReplyThis text comes from the changelog, so I suppose it has been tested -
core-ci voted on patch set 2 V +1 08/17/24, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63615
-
Lina Wolf commented on patch set 5 08/17/24, 08:06
Published edit on patch set 4. -
Lina Wolf commented on patch set 5 08/17/24, 08:06
ImageViewHelper.php:161ReplyDone -
core-ci voted on patch set 3 V +1 08/17/24, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63617
-
core-ci voted on patch set 4 V +1 08/17/24, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63618
-
core-ci voted on patch set 5 V +1 08/17/24, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63619
-
Garvin Hicking updated the commit message in patch set 6
V +108/17/24, 09:12 -
Garvin Hicking commented on patch set 6 08/17/24, 09:16
ImageViewHelper.php:158How about: If enabled, not the image's location will be used, but the contents of the file will be used, base64 encoded. Useful in FluidEmail context. -
Simon Praetorius commented on patch set 6 08/17/24, 09:18
ImageViewHelper.php:158Suggestion: Adds the image data base64-encoded inline to the image‘s "src" attribute. -
core-ci voted on patch set 6 V +1 08/17/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63623
-
Lina Wolf commented on patch set 7
V +108/17/24, 09:20Published edit on patch set 6. -
Lina Wolf commented on patch set 7 08/17/24, 09:21
ImageViewHelper.php:158ReplyDoneImageViewHelper.php:158ReplyI applied Simons suggestion as it sounds more fluid -
core-ci voted on patch set 7 V +1 08/17/24, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63629
-
Simon Praetorius voted on patch set 7 CR +1 V +1 08/17/24, 09:39
-
Christian Kuhn voted on patch set 7 CR +1 V +1 08/17/24, 09:54
-
Garvin Hicking updated the commit message in patch set 8
CR +1V +108/17/24, 10:56 -
Garvin Hicking voted on patch set 8 CR +2 V +2 08/17/24, 10:57
-
Garvin Hicking merged patch set 9 08/17/24, 10:57
-
core-ci voted on patch set 8 V +1 08/17/24, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63641