Review main Merged

85665[DOCS] Document base64 attribute of f:uri.image

TYPO3com CR +2 V +2 Easy +20 −1 updated 08/17/24, 11:09

Commit message

References:
https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/982

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2

Issues 2

Files 1

Review log 1926

Show 01 earlier messages
  1. TYPO3com uploaded patch set 1 08/17/24, 07:49

  1. core-ci voted on patch set 1 V -1 08/17/24, 07:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63614

  2. Lina Wolf commented on patch set 2 V -1 08/17/24, 07:56

    Published edit on patch set 1.
  3. Garvin Hicking commented on patch set 2 CR -1 08/17/24, 08:02

    duplicate?
  4. core-ci voted on patch set 2 V +1 08/17/24, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63616

  5. Lina Wolf commented on patch set 2 08/17/24, 08:07

    Reply

    Grr, wrong viewhelper
  6. Lina Wolf commented on patch set 2 CR -1 V -1 08/17/24, 08:08

    Working on it
  7. Lina Wolf voted on patch set 2 CR 0 V 0 08/17/24, 08:09

  8. Lina Wolf commented on patch set 2 08/17/24, 08:10

    Reply

    Nope, this is actually the f:uri.image ViewHelper. https://review.typo3.org/c/Packages/TYPO3.CMS/+/85664 documents the f:image viewhelper
  9. Lina Wolf commented on patch set 3 CR -1 V +1 08/17/24, 08:11

    Published edit on patch set 2.
  10. core-ci voted on patch set 3 V +1 08/17/24, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63620

  11. Garvin Hicking updated the commit message in patch set 4 V +1 08/17/24, 09:13

  12. Simon Praetorius voted on patch set 4 CR +1 V +1 08/17/24, 09:15

  13. Garvin Hicking commented on patch set 4 08/17/24, 09:15

    ImageViewHelper.php:115

    Indentation with tab

    ImageViewHelper.php:145

    Needs phrasing aligned with spelling and wording of f:image
  14. Lina Wolf commented on patch set 5 CR +1 V +1 08/17/24, 09:18

    Published edit on patch set 4.
  15. Lina Wolf commented on patch set 5 08/17/24, 09:19

    ImageViewHelper.php:115 Reply

    Done

    ImageViewHelper.php:145 Reply

    Nope, the viewhelper does not work the same way. The f:uri.image viewhelper directly returns the base64 encoded image while the f:image viewhelper outputs an img tag with the base 64 encoded image in its src property. So they do not work the same therefore the explanaition cannot be the same
  16. core-ci voted on patch set 4 V +1 08/17/24, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63624

  17. Simon Praetorius voted on patch set 5 CR +1 V +1 08/17/24, 09:29

  18. core-ci voted on patch set 5 V +1 08/17/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63628

  19. Christian Kuhn voted on patch set 5 CR +2 V +2 08/17/24, 09:54

  20. Christian Kuhn voted on patch set 5 CR +1 V +1 08/17/24, 09:54

  21. Garvin Hicking voted on patch set 5 CR +2 V +2 08/17/24, 10:58

  22. Garvin Hicking updated the commit message in patch set 6 CR +1 V +1 08/17/24, 10:58

  23. Garvin Hicking voted on patch set 6 CR +2 V +2 08/17/24, 10:58

  24. Garvin Hicking merged patch set 7 08/17/24, 10:59

  25. core-ci voted on patch set 6 V +1 08/17/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63643