85665[DOCS] Document base64 attribute of f:uri.image
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
-
Verified V +2 Done
- Garvin Hicking +2
Issues 2
Files 1
Review log 1926
Show 01 earlier messages
-
TYPO3com uploaded patch set 1 08/17/24, 07:49
-
core-ci voted on patch set 1 V -1 08/17/24, 07:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63614
-
Lina Wolf commented on patch set 2
V -108/17/24, 07:56Published edit on patch set 1. -
Garvin Hicking commented on patch set 2 CR -1 08/17/24, 08:02
duplicate? -
core-ci voted on patch set 2 V +1 08/17/24, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63616
-
Lina Wolf commented on patch set 2 08/17/24, 08:07
Reply
Grr, wrong viewhelper -
Lina Wolf commented on patch set 2 CR -1 V -1 08/17/24, 08:08
Working on it -
Lina Wolf voted on patch set 2 CR 0 V 0 08/17/24, 08:09
-
Lina Wolf commented on patch set 2 08/17/24, 08:10
Reply
Nope, this is actually the f:uri.image ViewHelper. https://review.typo3.org/c/Packages/TYPO3.CMS/+/85664 documents the f:image viewhelper -
Lina Wolf commented on patch set 3
CR -1V +108/17/24, 08:11Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 08/17/24, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63620
-
Garvin Hicking updated the commit message in patch set 4
V +108/17/24, 09:13 -
Simon Praetorius voted on patch set 4 CR +1 V +1 08/17/24, 09:15
-
Garvin Hicking commented on patch set 4 08/17/24, 09:15
ImageViewHelper.php:115Indentation with tabImageViewHelper.php:145Needs phrasing aligned with spelling and wording of f:image -
Lina Wolf commented on patch set 5
CR +1V +108/17/24, 09:18Published edit on patch set 4. -
Lina Wolf commented on patch set 5 08/17/24, 09:19
ImageViewHelper.php:115ReplyDoneImageViewHelper.php:145ReplyNope, the viewhelper does not work the same way. The f:uri.image viewhelper directly returns the base64 encoded image while the f:image viewhelper outputs an img tag with the base 64 encoded image in its src property. So they do not work the same therefore the explanaition cannot be the same -
core-ci voted on patch set 4 V +1 08/17/24, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63624
-
Simon Praetorius voted on patch set 5 CR +1 V +1 08/17/24, 09:29
-
core-ci voted on patch set 5 V +1 08/17/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63628
-
Christian Kuhn voted on patch set 5 CR +2 V +2 08/17/24, 09:54
-
Christian Kuhn voted on patch set 5 CR +1 V +1 08/17/24, 09:54
-
Garvin Hicking voted on patch set 5 CR +2 V +2 08/17/24, 10:58
-
Garvin Hicking updated the commit message in patch set 6
CR +1V +108/17/24, 10:58 -
Garvin Hicking voted on patch set 6 CR +2 V +2 08/17/24, 10:58
-
Garvin Hicking merged patch set 7 08/17/24, 10:59
-
core-ci voted on patch set 6 V +1 08/17/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63643