85670[TASK] Deprecate `tableoptions` and `collate` connection config
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Anja Leichsenring +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 5
- Task #105297Deprecate `tableoptions` and `collate` connection configuration
- Task #105289Mitigate deprecated Doctrine DBAL connection options
- Task #105288Update `typo3/testing-framework`
- Bug #97961Transform `tableoptions` early to valid `doctrine/dbal` option
- Feature #80398Make default charset and collation for new tables configurable
Files 2
Review log 1522
-
Stefan Bürk uploaded patch set 1 08/17/24, 12:31
-
core-ci voted on patch set 1 V +1 08/17/24, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63654
-
Stefan Bürk uploaded patch set 2
V +110/13/24, 16:25 -
core-ci voted on patch set 2 V +1 10/13/24, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67710
-
Stefan Bürk uploaded patch set 3
V +110/13/24, 17:01 -
core-ci voted on patch set 3 V +1 10/13/24, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67714
-
Garvin Hicking commented on patch set 3 10/13/24, 18:25
ConnectionPool.php:217'collate' also in quotesDeprecation-105297-DeprecateTableoptionsAndCollateConnectionConfiguration.rst:14Needs some rephrasing but can be done in follow-up, not blocking this -
Stefan Bürk commented on patch set 3 10/14/24, 04:31
ConnectionPool.php:203ReplyDoneConnectionPool.php:217ReplyDone -
Stefan Bürk uploaded patch set 4
V +110/14/24, 04:31 -
core-ci voted on patch set 4 V +1 10/14/24, 04:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67727
-
Garvin Hicking commented on patch set 5
V +110/14/24, 06:42Published edit on patch set 4. -
Garvin Hicking commented on patch set 6 10/14/24, 06:44
Published edit on patch set 5. -
Garvin Hicking commented on patch set 6 CR +1 V +1 10/14/24, 06:44
Deprecation-105297-DeprecateTableoptionsAndCollateConnectionConfiguration.rst:14ReplyDone -
core-ci voted on patch set 5 V +1 10/14/24, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67735
-
core-ci voted on patch set 6 V +1 10/14/24, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67736
-
Christian Kuhn uploaded patch set 7
CR +1V +110/14/24, 14:27 -
Christian Kuhn voted on patch set 7 CR +1 V +1 10/14/24, 14:29
-
Anja Leichsenring voted on patch set 7 CR +1 V +1 10/14/24, 14:30
-
Garvin Hicking voted on patch set 7 CR +1 V +1 10/14/24, 14:32
-
core-ci voted on patch set 7 V +1 10/14/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67764
-
Stefan Bürk voted on patch set 7 CR +2 V +2 10/14/24, 14:37
-
Stefan Bürk merged patch set 8 10/14/24, 14:37
ConnectionPool.php:203