Review main Merged

85670[TASK] Deprecate `tableoptions` and `collate` connection config

Stefan Bürk CR +2 V +2 Normal +109 −9 updated 10/14/24, 14:37

Commit message

This change deprecates the Database configuration
`tableoptions` in favour of `defaultTableOptions`
and `defaultTableOptions->collate` in favour of
`defaultTableOptions->collation` to align with
Doctrine DBAL changes [1].

[1] https://github.com/doctrine/dbal/pull/5246

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 5

Files 2

Review log 1522

  1. Stefan Bürk uploaded patch set 1 08/17/24, 12:31

  2. core-ci voted on patch set 1 V +1 08/17/24, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63654

  3. Stefan Bürk uploaded patch set 2 V +1 10/13/24, 16:25

  4. core-ci voted on patch set 2 V +1 10/13/24, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67710

  5. Stefan Bürk uploaded patch set 3 V +1 10/13/24, 17:01

  6. core-ci voted on patch set 3 V +1 10/13/24, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67714

  7. Garvin Hicking commented on patch set 3 10/13/24, 18:25

    ConnectionPool.php:203

    resolve this todk, add a todo for v14 to remove?

    ConnectionPool.php:217

    'collate' also in quotes

    Deprecation-105297-DeprecateTableoptionsAndCollateConnectionConfiguration.rst:14

    Needs some rephrasing but can be done in follow-up, not blocking this
  8. Stefan Bürk commented on patch set 3 10/14/24, 04:31

    ConnectionPool.php:203 Reply

    Done

    ConnectionPool.php:217 Reply

    Done
  9. Stefan Bürk uploaded patch set 4 V +1 10/14/24, 04:31

  10. core-ci voted on patch set 4 V +1 10/14/24, 04:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67727

  11. Garvin Hicking commented on patch set 5 V +1 10/14/24, 06:42

    Published edit on patch set 4.
  12. Garvin Hicking commented on patch set 6 10/14/24, 06:44

    Published edit on patch set 5.
  13. Garvin Hicking commented on patch set 6 CR +1 V +1 10/14/24, 06:44

    Deprecation-105297-DeprecateTableoptionsAndCollateConnectionConfiguration.rst:14 Reply

    Done
  14. core-ci voted on patch set 5 V +1 10/14/24, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67735

  15. core-ci voted on patch set 6 V +1 10/14/24, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67736

  16. Christian Kuhn uploaded patch set 7 CR +1 V +1 10/14/24, 14:27

  17. Christian Kuhn voted on patch set 7 CR +1 V +1 10/14/24, 14:29

  18. Anja Leichsenring voted on patch set 7 CR +1 V +1 10/14/24, 14:30

  19. Garvin Hicking voted on patch set 7 CR +1 V +1 10/14/24, 14:32

  20. core-ci voted on patch set 7 V +1 10/14/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67764

  21. Stefan Bürk voted on patch set 7 CR +2 V +2 10/14/24, 14:37

  22. Stefan Bürk merged patch set 8 10/14/24, 14:37