Review main Merged

85680[TASK] Deprecate BackendUtility::thumbCode()

Oli Bartsch CR +2 V +2 Normal +102 −1 updated 09/09/24, 09:43

Commit message

The method is unused in core and also is considered
bad API, e.g. because of a couple of method arguments
are unused, while other have been added over time
to change behaviour.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Jochen Roth +1
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Jochen Roth +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1619

  1. Oli Bartsch uploaded patch set 1 08/19/24, 15:45

  2. core-ci voted on patch set 1 V +1 08/19/24, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63777

  3. Oli Bartsch uploaded patch set 2 V +1 08/27/24, 06:29

  4. core-ci voted on patch set 2 V +1 08/27/24, 06:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64268

  5. Benni Mack commented on patch set 2 08/27/24, 06:42

    Deprecation-104662-BackendUtilityThumbCode.rst:38

    how about some hints on what to use instead (in v13) such as using the Record API?
  6. Oli Bartsch commented on patch set 2 08/27/24, 09:21

    Deprecation-104662-BackendUtilityThumbCode.rst:38 Reply

    I don't see how the Record API is involved here.
  7. Garvin Hicking commented on patch set 2 09/09/24, 08:16

    Deprecation-104662-BackendUtilityThumbCode.rst:38 Reply

    There are a few extensions out there using this (e.g. generic_gallery, templatevoilaplus) and possible custom implementations, so it would be nice if we have a better suggestion than just to say 'copy it', especially if the argument is "don't copy it, this is bad code currently")?
  8. Jochen Roth voted on patch set 2 CR +1 V +1 09/09/24, 08:20

  9. Oli Bartsch uploaded patch set 3 CR +1 V +1 09/09/24, 08:46

  10. Oli Bartsch commented on patch set 3 09/09/24, 08:48

    Deprecation-104662-BackendUtilityThumbCode.rst:38 Reply

    Done
  11. Jochen Roth voted on patch set 3 CR +1 V +1 09/09/24, 08:49

  12. core-ci voted on patch set 3 V +1 09/09/24, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65065

  13. Garvin Hicking commented on patch set 3 09/09/24, 08:58

    Deprecation-104662-BackendUtilityThumbCode.rst:38 Reply

    Thanks, that helps a lot to understand the code. Wouldn it be an option to introduce a new "thumbCode" API method, with a new name like "renderFileThumbnail" or whatever, and removes the old cruft? Then the migration path would be much easier...?
  14. Andreas Nedbal voted on patch set 3 CR +1 V +1 09/09/24, 08:59

  15. Oli Bartsch commented on patch set 3 09/09/24, 09:06

    Deprecation-104662-BackendUtilityThumbCode.rst:38 Reply

    Sounds good but we should do this in a separat patch IMO.
  16. Stefan Bürk voted on patch set 3 CR +1 V +1 09/09/24, 09:30

  17. Garvin Hicking commented on patch set 3 CR +1 V +1 09/09/24, 09:34

    We might want to create a new API for this, as we currently use functionality like this with 3 custom implementatons in: - typo3/sysext/backend/Classes/Form/Container/FileReferenceContainer.php - typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php - typo3/sysext/filelist/Classes/FileList.php
  18. Oli Bartsch voted on patch set 3 CR +2 V +2 09/09/24, 09:43

  19. Oli Bartsch merged patch set 4 09/09/24, 09:43