Review main Abandoned

85695[BUGFIX] Handle deleted records with FlexForm in history

Daniel Siepmann CR 0 V 0 Easy +1 −1 updated 08/20/24, 09:00

Commit message

The history will show differences for previous edits of records.
Those records might be deleted.
The FlexFormValueFormatter would fetch the record in order to provide
info about modified FlexForm values.

The formatter did not fetch deleted records, leading to an exception
further down the road where the record is validated. The pointer field
is checked, which would not exist in an empty record.

Therefore the deleted records are also fetched now.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 4

  1. Daniel Siepmann uploaded patch set 1 08/20/24, 08:57

  2. Daniel Siepmann commented on patch set 1 08/20/24, 08:59

    FlexFormValueFormatter.php:48 Unresolved

    I'm not sure whether this would open an information disclosure. This should be save within the history handling, but I'm not sure if the Formatter is used in other contexts now, or in future. So maybe there needs to be a different concept or way to handle the issue.
  3. Daniel Siepmann marked it work in progress 08/20/24, 08:59

  4. Daniel Siepmann abandoned the change 08/20/24, 09:00

    based on older code, this got already fixed in the meantime