Review main Merged

85701[TASK] Avoid TYPO3_REQUEST in fluid functional tests

Christian Kuhn CR +2 V +2 Normal +35 −85 updated 08/20/24, 20:51

Commit message

Various ext:fluid functional tests set
$GLOBALS['TYPO3_REQUEST']. There are three
scenarious fixed with this change:

* A VH uses ContentObjectRenderer that is
  fetched from request attribute
  'currentContentObject'. If the request
  has not been set up correctly, it falls
  back to globals. Set those properly.
* Setting $GLOBALS['TYPO3_REQUEST'] is
  not needed at all.
* The VH triggers extbase request dependent
  ConfigurationManager, which is not set
  up properly. Set up those.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 914

  1. Christian Kuhn uploaded patch set 1 08/20/24, 19:30

  2. core-ci voted on patch set 1 V -1 08/20/24, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63846

  3. Christian Kuhn uploaded patch set 2 V -1 08/20/24, 19:37

  4. core-ci voted on patch set 2 V -1 08/20/24, 19:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63847

  5. Christian Kuhn uploaded patch set 3 V -1 08/20/24, 19:43

  6. core-ci voted on patch set 3 V +1 08/20/24, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63848

  7. Christian Kuhn uploaded patch set 4 V +1 08/20/24, 20:25

  8. Christian Kuhn updated the commit message in patch set 5 08/20/24, 20:32

  9. core-ci voted on patch set 4 V +1 08/20/24, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63855

  10. core-ci voted on patch set 5 V +1 08/20/24, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63857

  11. Simon Praetorius voted on patch set 5 CR +1 V +1 08/20/24, 20:44

  12. Stefan Bürk voted on patch set 5 CR +1 V +1 08/20/24, 20:48

  13. Christian Kuhn voted on patch set 5 CR +2 V +2 08/20/24, 20:51

  14. Christian Kuhn merged patch set 6 08/20/24, 20:51