Review main Merged

85702[TASK] Avoid globals COR TYPO3_REQUEST in typolink VHs

Christian Kuhn CR +2 V +2 Normal +42 −38 updated 08/20/24, 20:19

Commit message

View helpers link.typolink and uri.typolink fail to
set the given request on ContentObjectRenderer, so
it falls back to $GLOBALS['TYPO3_REQUEST']. The patch
sets the request (if given), and adapts the tests to
rely on it, which avoid setting the global.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 710

  1. Christian Kuhn uploaded patch set 1 08/20/24, 19:59

  2. Christian Kuhn uploaded patch set 2 08/20/24, 20:02

  3. Christian Kuhn updated the commit message in patch set 3 08/20/24, 20:06

  4. core-ci voted on patch set 1 V +1 08/20/24, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63850

  5. core-ci voted on patch set 2 V +1 08/20/24, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63851

  6. Stefan Bürk voted on patch set 3 CR +1 V +1 08/20/24, 20:09

  7. Simon Praetorius voted on patch set 3 CR +1 V +1 08/20/24, 20:10

  8. core-ci voted on patch set 3 V +1 08/20/24, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63853

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 08/20/24, 20:19

  10. Christian Kuhn merged patch set 4 08/20/24, 20:19