Review main Merged

85706[TASK] Reduce TYPO3_REQUEST in extbase functional tests

Christian Kuhn CR +2 V +2 Hard +58 −234 updated 08/21/24, 09:21

Commit message

Various ext:extbase functional tests set
$GLOBALS['TYPO3_REQUEST']. The extbase
codebase still has various places that
access the global.

We can still reduce some usages in tests which
are obsolete meanwhile, or can be improved by
setting the request on ConfigurationManager
instead, which is one of the main callers to
the $GLOBALS['TYPO3_REQUEST'] fallback in tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 2

Files 36

Show 16 more files

Review log 68

  1. Christian Kuhn uploaded patch set 1 08/21/24, 06:37

  2. core-ci voted on patch set 1 V +1 08/21/24, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63879

  3. Christian Kuhn uploaded patch set 2 V +1 08/21/24, 08:04

  4. core-ci voted on patch set 2 V +1 08/21/24, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63883

  5. Simon Praetorius voted on patch set 2 CR +1 V +1 08/21/24, 08:44

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 08/21/24, 09:19

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 08/21/24, 09:21

  8. Christian Kuhn merged patch set 3 08/21/24, 09:21