85707[TASK] Use proper `<template>` tags for Install Tool fragments
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Nedbal +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Nedbal +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 16
- Build/Sources/TypeScript/install/module/environment/image-processing.ts+3 −4
- Build/Sources/TypeScript/install/module/maintenance/clear-tables.ts+3 −4
- Build/Sources/TypeScript/install/module/maintenance/clear-typo3temp-files.ts+3 −4
- Build/Sources/TypeScript/install/module/maintenance/database-analyzer.ts+4 −5
- Build/Sources/TypeScript/install/module/upgrade/upgrade-wizards.ts+18 −22
- typo3/sysext/install/Resources/Private/Templates/Environment/ImageProcessing.html+16 −18
- typo3/sysext/install/Resources/Private/Templates/Maintenance/ClearTables.html+13 −18
- typo3/sysext/install/Resources/Private/Templates/Maintenance/ClearTypo3tempFiles.html+12 −20
- typo3/sysext/install/Resources/Private/Templates/Maintenance/DatabaseAnalyzer.html+40 −40
- typo3/sysext/install/Resources/Private/Templates/Maintenance/LanguagePacks.html3+0 −6
- typo3/sysext/install/Resources/Private/Templates/Upgrade/UpgradeWizards.html+87 −87
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/image-processing.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/clear-tables.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/clear-typo3temp-files.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/database-analyzer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/upgrade-wizards.js+1 −1
Review log 910
-
Andreas Kienast uploaded patch set 1 08/21/24, 09:56
-
Andreas Kienast uploaded patch set 2 08/21/24, 09:59
-
Andreas Kienast uploaded patch set 3 08/21/24, 10:01
-
core-ci voted on patch set 3 V +1 08/21/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63893
-
Garvin Hicking commented on patch set 3 CR +1 V +1 08/22/24, 07:51
Tested and compared with Chrome and FF (mac)LanguagePacks.html:7This was dead code, right? Didn't know how to see this in the "before" state. -
Andreas Kienast commented on patch set 3 08/22/24, 08:07
LanguagePacks.html:7ReplyYes. Probably a left over from the latest refactorings in that area. -
Garvin Hicking commented on patch set 3 08/22/24, 08:47
LanguagePacks.html:7ReplyDone -
Andreas Nedbal voted on patch set 3 CR +1 V +1 08/22/24, 09:44
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 08/22/24, 09:47
-
Benjamin Franzke merged patch set 4 08/22/24, 09:47