Review main Merged

85707[TASK] Use proper `<template>` tags for Install Tool fragments

Andreas Kienast CR +2 V +2 Hard +204 −233 updated 08/22/24, 09:47

Commit message

The Install Tool templates now incorporate `<template>` tags that
replace the previously used hidden `<div>` elements that served the same
purpose: have re-usable templates.

Using `<template>` allows us to remove some more quirks in the code,
e.g. removing the template identifier classes (which wasn't done
everywhere) and the requirement for valid markup within the templates,
as `<template>.content` resolves to a `DocumentFragment` in JavaScript.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 910

  1. Andreas Kienast uploaded patch set 1 08/21/24, 09:56

  2. Andreas Kienast uploaded patch set 2 08/21/24, 09:59

  3. Andreas Kienast uploaded patch set 3 08/21/24, 10:01

  4. core-ci voted on patch set 3 V +1 08/21/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63893

  5. Garvin Hicking commented on patch set 3 CR +1 V +1 08/22/24, 07:51

    Tested and compared with Chrome and FF (mac)

    LanguagePacks.html:7

    This was dead code, right? Didn't know how to see this in the "before" state.
  6. Andreas Kienast commented on patch set 3 08/22/24, 08:07

    LanguagePacks.html:7 Reply

    Yes. Probably a left over from the latest refactorings in that area.
  7. Garvin Hicking commented on patch set 3 08/22/24, 08:47

    LanguagePacks.html:7 Reply

    Done
  8. Andreas Nedbal voted on patch set 3 CR +1 V +1 08/22/24, 09:44

  9. Benjamin Franzke voted on patch set 3 CR +2 V +2 08/22/24, 09:47

  10. Benjamin Franzke merged patch set 4 08/22/24, 09:47