Review main Merged

85709[TASK] Install Tool: Re-structure removal views

Andreas Kienast CR +2 V +2 Easy +32 −14 updated 08/23/24, 10:21

Commit message

The Install Tool sections "Remove Temporary Assets" and "Clear
Persistent Database Tables" have been re-structured a bit to have a
cleaner look.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2029

Show 34 earlier messages
  1. Andreas Kienast uploaded patch set 1 08/21/24, 13:30

  2. Andreas Kienast commented on patch set 1 CR -2 08/21/24, 13:30

  3. core-ci voted on patch set 1 V +1 08/21/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63914

  4. Andreas Kienast uploaded patch set 2 V +1 08/22/24, 05:58

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  1. core-ci voted on patch set 2 V +1 08/22/24, 06:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63954

  2. Andreas Kienast uploaded patch set 3 V +1 08/22/24, 14:14

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  3. Andreas Kienast voted on patch set 3 CR 0 08/22/24, 14:14

  4. Andreas Kienast commented on patch set 3 08/22/24, 14:14

    Reply

    Done
  5. Andreas Kienast uploaded patch set 4 08/22/24, 14:15

  6. core-ci voted on patch set 3 V +1 08/22/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63994

  7. core-ci voted on patch set 4 V +1 08/22/24, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63995

  8. Garvin Hicking commented on patch set 4 08/22/24, 17:51

    Typo3tempFileService.php:143

    (as noted, this may cause intensive/costy lookups on remote storages; maybe check ic a storage is local?)
  9. Benjamin Franzke commented on patch set 4 08/23/24, 06:32

    _install.scss:134

    `var(--typo3-spacing)`
  10. Andreas Kienast commented on patch set 4 08/23/24, 06:51

    _install.scss:134 Reply

    Acknowledged

    Typo3tempFileService.php:143 Reply

    If I read the code correctly, `_processed_` is not bound to the `Local` driver.
  11. Andreas Kienast uploaded patch set 5 V +1 08/23/24, 07:16

  12. Andreas Kienast uploaded patch set 6 08/23/24, 07:16

  13. core-ci voted on patch set 5 V -1 08/23/24, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64050

  14. core-ci voted on patch set 6 V +1 08/23/24, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64052

  15. Andreas Kienast commented on patch set 6 CR -1 08/23/24, 07:29

    Typo3tempFileService.php:143 Reply

    Will remove the code again as it causes more issues as it helps.
  16. Andreas Kienast uploaded patch set 7 CR -1 V +1 08/23/24, 07:31

  17. Andreas Kienast uploaded patch set 8 08/23/24, 07:32

  18. core-ci voted on patch set 7 V -1 08/23/24, 07:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64053

  19. core-ci voted on patch set 8 V -1 08/23/24, 07:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64054

  20. Andreas Kienast uploaded patch set 9 V -1 08/23/24, 07:48

  21. core-ci voted on patch set 9 V +1 08/23/24, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64055

  22. Benjamin Franzke voted on patch set 9 CR +1 V +1 08/23/24, 07:56

  23. Garvin Hicking voted on patch set 9 CR +1 V +1 08/23/24, 08:27

  24. Andreas Kienast voted on patch set 9 CR +2 V +2 08/23/24, 10:21

  25. Andreas Kienast merged patch set 10 08/23/24, 10:21