85709[TASK] Install Tool: Re-structure removal views
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2029
Show 34 earlier messages
-
Andreas Kienast uploaded patch set 1 08/21/24, 13:30
-
Andreas Kienast commented on patch set 1 CR -2 08/21/24, 13:30
Should go in after https://review.typo3.org/c/Packages/TYPO3.CMS/+/85707 -
core-ci voted on patch set 1 V +1 08/21/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63914
-
Andreas Kienast uploaded patch set 2
V +108/22/24, 05:58Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
-
core-ci voted on patch set 2 V +1 08/22/24, 06:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63954
-
Andreas Kienast uploaded patch set 3
V +108/22/24, 14:14Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Andreas Kienast voted on patch set 3 CR 0 08/22/24, 14:14
-
Andreas Kienast commented on patch set 3 08/22/24, 14:14
Reply
Done -
Andreas Kienast uploaded patch set 4 08/22/24, 14:15
-
core-ci voted on patch set 3 V +1 08/22/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63994
-
core-ci voted on patch set 4 V +1 08/22/24, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63995
-
Garvin Hicking commented on patch set 4 08/22/24, 17:51
Typo3tempFileService.php:143(as noted, this may cause intensive/costy lookups on remote storages; maybe check ic a storage is local?) -
Benjamin Franzke commented on patch set 4 08/23/24, 06:32
_install.scss:134`var(--typo3-spacing)` -
Andreas Kienast commented on patch set 4 08/23/24, 06:51
_install.scss:134ReplyAcknowledgedTypo3tempFileService.php:143ReplyIf I read the code correctly, `_processed_` is not bound to the `Local` driver. -
Andreas Kienast uploaded patch set 5
V +108/23/24, 07:16 -
Andreas Kienast uploaded patch set 6 08/23/24, 07:16
-
core-ci voted on patch set 5 V -1 08/23/24, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64050
-
core-ci voted on patch set 6 V +1 08/23/24, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64052
-
Andreas Kienast commented on patch set 6 CR -1 08/23/24, 07:29
Typo3tempFileService.php:143ReplyWill remove the code again as it causes more issues as it helps. -
Andreas Kienast uploaded patch set 7
CR -1V +108/23/24, 07:31 -
Andreas Kienast uploaded patch set 8 08/23/24, 07:32
-
core-ci voted on patch set 7 V -1 08/23/24, 07:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64053
-
core-ci voted on patch set 8 V -1 08/23/24, 07:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64054
-
Andreas Kienast uploaded patch set 9
V -108/23/24, 07:48 -
core-ci voted on patch set 9 V +1 08/23/24, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64055
-
Benjamin Franzke voted on patch set 9 CR +1 V +1 08/23/24, 07:56
-
Garvin Hicking voted on patch set 9 CR +1 V +1 08/23/24, 08:27
-
Andreas Kienast voted on patch set 9 CR +2 V +2 08/23/24, 10:21
-
Andreas Kienast merged patch set 10 08/23/24, 10:21