Review main Merged

85710[BUGFIX] Make Fluid DebuggerUtility css more safe against custom css

Karsten Nowak CR +2 V +2 Easy +1 −1 updated 08/21/24, 18:34

Commit message

Fix not cklickable `+` sign for the nested properties in debugger
tree in frontend.
The css selector for input fields of type checkbox are not strong enough
if the website css defines own css rules and select checkboxes with

input[type="checkbox"]

the selector in DebuggerUtility loses and properties are overriden.
Height, width, z-index and other properties were used to hide the
default appearance of checkboxes and make those form elements looking
nice. Therefore, DebuggerUtilitys selector should be a bit more
stronger.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Karsten Nowak uploaded patch set 1 08/21/24, 14:44

  2. core-ci voted on patch set 1 V +1 08/21/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63918

  3. Christian Kuhn commented on patch set 1 08/21/24, 18:24

    Ok, here is the thing: Overall, DebuggerUtility should create a web component which would separate the 'global' CSS away in this scope. This however is a far bigger change, while this patch is about a minor detail. As such, we're not really happy with this change, but tend to accept it nevertheless. Thank you for your patch :)
  4. Anja Leichsenring voted on patch set 1 CR +1 V +1 08/21/24, 18:33

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 08/21/24, 18:33

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 08/21/24, 18:34

  7. Christian Kuhn merged patch set 2 08/21/24, 18:34