Review main Abandoned

85714[BUGFIX] Increase size of scope field in sys_http_report

Koop Mast CR 0 V 0 Easy +1 −1 updated 12/17/24, 20:26

Commit message

In frontend context the field scope in table sys_http_report is
filled with a concatenation of "frontend." and the site configuration
identifier. When the site identifier is too long, new entries in
sys_http_report fail for frontend CSP validation failure reports.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 67

  1. Koop Mast uploaded patch set 1 08/22/24, 07:20

  2. Andreas Kienast commented on patch set 1 CR -1 08/22/24, 07:23

    Hey. Thank you for your patch. There's already another one, tackling the exact same issue: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85295
  3. core-ci voted on patch set 1 V +1 08/22/24, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63958

  4. Benni Mack updated the commit message in patch set 2 CR -1 V +1 10/18/24, 13:43

  5. Benni Mack rebased onto patch set 3 12/17/24, 20:25

    The following files contain Git conflicts: * typo3/sysext/core/ext_tables.sql
  6. Benni Mack commented on patch set 4 12/17/24, 20:25

    Published edit on patch set 3.
  7. Benni Mack abandoned the change 12/17/24, 20:26

    abandoning the change, as there was another one and no response since august