Review 12.4 Merged

85716[BUGFIX] Wrong index in BackendLayoutView::getColPosListItemsParsed

Thomas Hohn CR +2 V +2 Easy +1 −1 updated 09/05/24, 09:26

Commit message

The method BackendLayoutView::getColPosListItemsParsed removes items
configured in TCEFORM.tt_content.colPos.removeItems.
However $item[1] was used instead of $item['value'], which leads to
a PHP warning "Undefined array key 1".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Thomas Hohn uploaded patch set 1 08/22/24, 08:00

  2. core-ci voted on patch set 1 V +1 08/22/24, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63961

  3. Andreas Kienast voted on patch set 1 CR +1 08/22/24, 08:30

  4. Benni Mack voted on patch set 1 CR +2 V +2 09/05/24, 09:26

  5. Benni Mack merged patch set 2 09/05/24, 09:26