Review main Merged

85718[TASK] Happify phpstan in ext:install tests

Christian Kuhn CR +2 V +2 Easy +5 −20 updated 08/22/24, 09:48

Commit message

fix() is annotated to return an array of
FlashMessages, the test setup returns an
array of strings instead. Adapt the tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 78

  1. Christian Kuhn uploaded patch set 1 08/22/24, 08:26

  2. Thomas Hohn voted on patch set 1 CR +1 08/22/24, 08:29

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 08/22/24, 08:29

  4. core-ci voted on patch set 1 V +1 08/22/24, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63963

  5. Andreas Kienast voted on patch set 1 CR +1 V +1 08/22/24, 08:32

  6. Thomas Hohn voted on patch set 1 V +1 08/22/24, 08:39

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 08/22/24, 09:48

  8. Christian Kuhn merged patch set 2 08/22/24, 09:48