Review main Abandoned

85719[BUGFIX] Remove marking of all form fields as changed for new record

Ayke Halder CR 0 V 0 Easy +4 −1 updated 09/10/24, 09:17

Commit message

This adds a placeholder for new records to only mark the form as
'changed' for the save-changes-on-close trigger.

This prevents all form fields from being visually marked as 'changed'
per default for new records.

Review

  • Code review CR 0
  • Verified V 0

Issues 3

Files 1

Review log 812

  1. Ayke Halder uploaded patch set 1 08/22/24, 08:41

  2. Ayke Halder updated the commit message in patch set 2 08/22/24, 08:43

  3. core-ci voted on patch set 1 V -1 08/22/24, 08:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63964

  4. core-ci voted on patch set 2 V +1 08/22/24, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63966

  5. core-ci voted on patch set 1 V -1 08/22/24, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63964

  6. core-ci voted on patch set 1 V +1 08/22/24, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63964

  7. Andreas Kienast voted on patch set 2 CR +1 08/22/24, 09:22

  8. Andreas Kienast voted on patch set 2 V +1 08/22/24, 12:29

  9. Benni Mack commented on patch set 2 09/05/24, 13:31

    How about we add a new class "is-new-record" instead of "has-changed"?
  10. Ayke Halder commented on patch set 2 09/05/24, 14:34

    Reply

    I want to go for a hassle-free backport to v12 here. But for sure we can go for `class="is-new-record"` with an additional change of the JS code. There was some discussion about this 'quick-fix' here: https://typo3.slack.com/archives/C03AM9R17/p1724315002216359?thread_ts=1724231569.538239&cid=C03AM9R17 The code gets re-implemented in v14 anyway. So how shall we proceed?
  11. Benjamin Kott commented on patch set 2 09/10/24, 09:16

    We are abandoning this change in favor of the following as this one only covers the underlying problem. https://review.typo3.org/c/Packages/TYPO3.CMS/+/85975
  12. Benjamin Kott abandoned the change 09/10/24, 09:17