Review main Merged

85725[TASK] Make panels context aware

Benjamin Kott CR +2 V +2 Nightmare +2043 −1809 updated 09/09/24, 09:16

Commit message

The new panel element styling is context aware and
adapts to light and dark color schemes. The markup
was streamlined, workarounds dropped and now
features improved focus and hover styles.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 2

Files 66

Show 46 more files

Review log 3560

Show 1835 earlier messages
  1. Benjamin Kott uploaded patch set 1 08/22/24, 11:51

  2. core-ci voted on patch set 1 V -1 08/22/24, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63982

  3. Jasmina Ließmann commented on patch set 1 09/01/24, 20:22

    As a note: There is already an "Accordion" page in EXT:styleguide which contains a simple panel. Perhaps the existing page and the new "Panels" page from this patch could be merged?
  4. Benjamin Kott uploaded patch set 2 V -1 09/02/24, 06:26

  5. core-ci voted on patch set 2 V +1 09/02/24, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64619

  6. Benjamin Kott uploaded patch set 3 V +1 09/02/24, 07:59

  7. core-ci voted on patch set 3 V +1 09/02/24, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64626

  8. Benjamin Kott uploaded patch set 4 V +1 09/03/24, 14:28

  9. core-ci voted on patch set 4 V -1 09/03/24, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64671

  10. Benjamin Kott uploaded patch set 5 V -1 09/04/24, 13:55

  11. Benjamin Kott updated the commit message in patch set 6 09/04/24, 14:05

  12. core-ci voted on patch set 5 V -1 09/04/24, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64764

  13. core-ci voted on patch set 6 V -1 09/04/24, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64767

  14. Benjamin Kott uploaded patch set 7 V -1 09/05/24, 07:44

  15. core-ci voted on patch set 7 V -1 09/05/24, 07:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64837

  16. Benjamin Kott uploaded patch set 8 V -1 09/05/24, 13:28

  17. core-ci voted on patch set 8 V -1 09/05/24, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64866

  18. Benjamin Kott uploaded patch set 9 V -1 09/05/24, 14:29

  19. core-ci voted on patch set 9 V -1 09/05/24, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64869

  20. Benjamin Kott uploaded patch set 10 V -1 09/06/24, 08:39

  21. core-ci voted on patch set 10 V -1 09/06/24, 08:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64918

  22. Benjamin Kott uploaded patch set 11 V -1 09/06/24, 09:19

  23. core-ci voted on patch set 11 V -1 09/06/24, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64922

  24. Benjamin Kott uploaded patch set 12 V -1 09/06/24, 09:36

  25. Benjamin Kott uploaded patch set 13 09/06/24, 09:43

  26. core-ci voted on patch set 12 V -1 09/06/24, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64925

  27. core-ci voted on patch set 13 V -1 09/06/24, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64927

  28. Benjamin Kott uploaded patch set 14 V -1 09/06/24, 10:32

  29. core-ci voted on patch set 14 V -1 09/06/24, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64935

  30. Benjamin Kott uploaded patch set 15 V -1 09/06/24, 10:53

  31. core-ci voted on patch set 15 V -1 09/06/24, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64940

  32. Benjamin Kott uploaded patch set 16 V -1 09/06/24, 11:17

  33. Benjamin Kott uploaded patch set 17 09/06/24, 11:22

  34. core-ci voted on patch set 16 V -1 09/06/24, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64945

  35. core-ci voted on patch set 17 V -1 09/06/24, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64946

  1. Benjamin Kott uploaded patch set 18 V -1 09/06/24, 11:36

  2. Benjamin Kott uploaded patch set 19 09/06/24, 11:44

  3. core-ci voted on patch set 18 V -1 09/06/24, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64947

  4. core-ci voted on patch set 19 V -1 09/06/24, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64949

  5. Benjamin Kott uploaded patch set 20 V -1 09/06/24, 11:56

  6. core-ci voted on patch set 20 V -1 09/06/24, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64950

  7. Jasmina Ließmann wrote 09/06/24, 12:07

    Removed cc Jasmina Ließmann.
  8. Benjamin Kott uploaded patch set 21 V -1 09/06/24, 12:33

  9. core-ci voted on patch set 21 V +1 09/06/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64952

  10. Benjamin Kott commented on patch set 21 09/06/24, 12:56

    Reply

    Done
  11. Benjamin Kott rebased onto patch set 22 V +1 09/06/24, 13:48

  12. Benjamin Kott uploaded patch set 23 09/06/24, 13:56

  13. core-ci voted on patch set 22 V +1 09/06/24, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64961

  14. Benjamin Kott uploaded patch set 24 09/06/24, 14:00

  15. core-ci voted on patch set 23 V +1 09/06/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64964

  16. core-ci voted on patch set 24 V +1 09/06/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64965

  17. Jasmina Ließmann commented on patch set 24 09/09/24, 07:46

    Is there a reason why the font weight of some panels was reduced from bold to regular? This has happened, for example, in the following cases: - Backend user group -> tab "Record Permissions" -> field "Allowed fields" - "Element information" modal

    ElementInformation.html:121

    Can we make this a h3, like it is for "Configuration" in the "Active TypoScript" submodule?

    ElementInformation.html:167

    See above.

    ElementInformation.html:213

    See above.
  18. Jasmina Ließmann commented on patch set 24 09/09/24, 07:46

    With this patch, the icon in the file reference panel has no mouse over effect. Without the patch, at least the immediate area around it had such a mouse over effect.
  19. Jasmina Ließmann commented on patch set 24 09/09/24, 07:46

    I noticed some changes in the direction of the collapse icon: 1) Module "List" - closed state: icon points downwards - open state: icon points upwards 2) Module "TypoScript" -> "Active TypoScript" - closed state: icon points to the right - open state: icon points downwards 3a) Backend user group -> Tab "Record Permissions" -> "Allowed fields" + 3b) Element information modal: - with this patch now has the same directions as in the "Active TypoScript" submodule - without this patch it has the same directions as in the "List" module For me the directions of the "List" module is more common/learned in the web. Maybe we can take the chance and unify the collapse icon direction by appling the directions of the "List" module to other panels?
  20. Benjamin Kott rebased onto patch set 25 V +1 09/09/24, 08:09

  21. core-ci voted on patch set 25 V +1 09/09/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65062

  22. Benjamin Kott commented on patch set 25 09/09/24, 08:47

    Reply

    There was no emphasis set by default, please see styleguide for the default values. if there is an emphasis needed here, it must be added now. there is no reason to make everything bold. it was kept in places where it was intentionally set.

    Reply

    The icon is only an indicator as the full title is not clickable, with underline indication for hover and full outline for focus visible.

    Reply

    There are still some places that are debatable. The default carets have been adjusted to match the "disclosure" pattern. Some places are kept as is, as they have special implementation that i tried to avoid touching here. See: - https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/examples/disclosure-navigation/ - https://developer.mozilla.org/en-US/docs/Web/CSS/list-style-type#disclosure-open https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details

    ElementInformation.html:121 Reply

    i tried to keep semantic html as before to avoid introducing issues. this can be done in a dedicated patch afterwards

    ElementInformation.html:167 Reply

    see above

    ElementInformation.html:213 Reply

    see above
  23. Andreas Nedbal voted on patch set 25 CR +1 V +1 09/09/24, 08:49

  24. Benjamin Franzke voted on patch set 25 CR +2 V +2 09/09/24, 09:16

  25. Benjamin Franzke merged patch set 26 09/09/24, 09:16