Review main Abandoned

85727[FEATURE] Introduce PSR-14 AfterUserLookupEvent

Oli Bartsch CR 0 V 0 Normal +159 −5 updated 12/05/24, 14:07

Commit message

The new PSR-14 AfterUserLookupEvent is
introduced, which works as a drop-in replacement
for the now deprecated $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['postUserLookUp']
hook, while providing more information,
e.g. the current PSR-14 Request.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 67

  1. Oli Bartsch uploaded patch set 1 08/22/24, 12:56

  2. Christian Kuhn commented on patch set 1 CR -1 08/22/24, 12:59

    AbstractUserAuthentication.php:297

    i'm against handing over $this/pObj as "do whatever you want" to the new event. this makes the entire class api. we should at least hand over only needed data instead when we're working on this topic without redesigning the entire authenticaton service mess before.
  3. core-ci voted on patch set 1 V -1 08/22/24, 13:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63984

  4. Chris Müller commented on patch set 1 08/22/24, 15:57

    Unresolved

    The rst files target 13.2 in changelog, but should target 13.3
  5. Oliver Hader updated the commit message in patch set 2 CR -1 V -1 10/18/24, 14:07

  6. Benni Mack commented on patch set 2 12/05/24, 11:34

    AbstractUserAuthentication.php:297 Reply Unresolved

    I think we can simply remove this hook as there are many other ways (PSR-15, T3_SERVICES etc) to solve this.
  7. Benni Mack abandoned the change 12/05/24, 14:07

    won't do