85731[TASK] Improve a11y of disabled multi-record-selection buttons
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Lina Wolf +1
-
Verified V +2 Done
- Benjamin Kott +2
- Lina Wolf +1
- core-ci +1 CI
Issues 1
Files 16
- Build/Sources/TypeScript/backend/multi-record-selection.ts+5 −6
- Build/Sources/TypeScript/workspaces/renderable/record-table.ts+2 −2
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php4+2 −2
- typo3/sysext/backend/Classes/Form/Element/TablePermissionElement.php+2 −2
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+7 −5
- typo3/sysext/backend/Resources/Public/JavaScript/multi-record-selection.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Recycler/RecyclerModuleCest.php+1 −0
- typo3/sysext/filelist/Classes/FileList.php+2 −2
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+4 −4
- typo3/sysext/reactions/Resources/Private/Templates/Management/Overview.html+2 −2
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule.html+2 −2
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+2 −2
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+4 −2
- typo3/sysext/webhooks/Resources/Private/Templates/Management/Overview.html+2 −2
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/record-table.js+2 −2
Review log 1728
Show 23 earlier messages
-
Ayke Halder uploaded patch set 1 08/22/24, 13:34
-
core-ci voted on patch set 1 V +1 08/22/24, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63988
-
Ayke Halder updated the commit message in patch set 2
V +108/22/24, 14:21
-
core-ci voted on patch set 2 V +1 08/22/24, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63996
-
Ayke Halder uploaded patch set 3
V +108/22/24, 15:15 -
core-ci voted on patch set 3 V +1 08/22/24, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63997
-
Ayke Halder commented on patch set 3 CR -1 09/04/24, 08:28
This change must be split into three distinct changes for better reviewability. -
Benjamin Franzke commented on patch set 3 09/04/24, 08:42
Reply
This patch isn't too large, it would actually be fine as-is (if it is fine with you).SelectCheckBoxElement.php:317Let's just write `disabled` instead of `disabled="disabled"` if we're writing plain HTML, no need for the unneeded value. (`disabled="disabled"` is fine if we need to provide some value because of fluid…)SelectCheckBoxElement.php:317`disabled` class should be removed, as we should style based on the `disabled` attribute -
Ayke Halder uploaded patch set 4
CR -1V +109/04/24, 13:58 -
core-ci voted on patch set 4 V +1 09/04/24, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64765
-
Ayke Halder uploaded patch set 5
V +109/04/24, 15:19 -
core-ci voted on patch set 5 V +1 09/04/24, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64776
-
Ayke Halder uploaded patch set 6
V +109/04/24, 15:56 -
core-ci voted on patch set 6 V +1 09/04/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64784
-
Ayke Halder uploaded patch set 7
V +109/04/24, 16:07 -
Ayke Halder uploaded patch set 8 09/04/24, 16:13
-
core-ci voted on patch set 7 V +1 09/04/24, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64786
-
Ayke Halder uploaded patch set 9 09/04/24, 16:16
-
Ayke Halder updated the commit message in patch set 10 09/04/24, 16:17
-
core-ci voted on patch set 8 V -1 09/04/24, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64787
-
core-ci voted on patch set 9 V -1 09/04/24, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64788
-
core-ci voted on patch set 10 V -1 09/04/24, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64789
-
Ayke Halder commented on patch set 10 09/04/24, 16:26
Reply
I've split this change now. See discussion about this: https://typo3.slack.com/archives/C108Q9E2C/p1725437761076499?thread_ts=1725356371.287499&cid=C108Q9E2COpen for thorough review now. I have split up the change, so this one becomes `multi-record-selection` only.SelectCheckBoxElement.php:317ReplyDoneSelectCheckBoxElement.php:317ReplyDone -
Ayke Halder uploaded patch set 11
V -109/04/24, 16:27 -
core-ci voted on patch set 11 V +1 09/04/24, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64791
-
Lina Wolf commented on patch set 11 CR +1 V +1 09/06/24, 14:24
Code looks good and works on my machine -
Benjamin Kott voted on patch set 11 CR +2 V +2 09/10/24, 09:23
-
Benjamin Kott merged patch set 12 09/10/24, 09:23