Review main Merged

85731[TASK] Improve a11y of disabled multi-record-selection buttons

Ayke Halder CR +2 V +2 Normal +42 −38 updated 09/10/24, 09:23

Commit message

This changes the `disabled`-attribute of the multi-record-selection
buttons. Thereby screenreaders can announce that a button is disabled.

Before this there was toggling implemented for `class="disabled"`.
Thereby a 'disabled' button was still active and could be activated by
keyboard.

Multi-record-selection buttons are implemented in these sections:

* TCA: SelectCheckboxElement
* TCA: TablePermissionElement
* backend: record-list
* filelist: list
* recycler: list
* redirects: overview
* scheduler: task-list
* webhooks: overview
* workspaces: record-table

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Lina Wolf +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1728

Show 23 earlier messages
  1. Ayke Halder uploaded patch set 1 08/22/24, 13:34

  2. core-ci voted on patch set 1 V +1 08/22/24, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63988

  3. Ayke Halder updated the commit message in patch set 2 V +1 08/22/24, 14:21

  1. core-ci voted on patch set 2 V +1 08/22/24, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63996

  2. Ayke Halder uploaded patch set 3 V +1 08/22/24, 15:15

  3. core-ci voted on patch set 3 V +1 08/22/24, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63997

  4. Ayke Halder commented on patch set 3 CR -1 09/04/24, 08:28

    This change must be split into three distinct changes for better reviewability.
  5. Benjamin Franzke commented on patch set 3 09/04/24, 08:42

    Reply

    This patch isn't too large, it would actually be fine as-is (if it is fine with you).

    SelectCheckBoxElement.php:317

    Let's just write `disabled` instead of `disabled="disabled"` if we're writing plain HTML, no need for the unneeded value. (`disabled="disabled"` is fine if we need to provide some value because of fluid…)

    SelectCheckBoxElement.php:317

    `disabled` class should be removed, as we should style based on the `disabled` attribute
  6. Ayke Halder uploaded patch set 4 CR -1 V +1 09/04/24, 13:58

  7. core-ci voted on patch set 4 V +1 09/04/24, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64765

  8. Ayke Halder uploaded patch set 5 V +1 09/04/24, 15:19

  9. core-ci voted on patch set 5 V +1 09/04/24, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64776

  10. Ayke Halder uploaded patch set 6 V +1 09/04/24, 15:56

  11. core-ci voted on patch set 6 V +1 09/04/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64784

  12. Ayke Halder uploaded patch set 7 V +1 09/04/24, 16:07

  13. Ayke Halder uploaded patch set 8 09/04/24, 16:13

  14. core-ci voted on patch set 7 V +1 09/04/24, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64786

  15. Ayke Halder uploaded patch set 9 09/04/24, 16:16

  16. Ayke Halder updated the commit message in patch set 10 09/04/24, 16:17

  17. core-ci voted on patch set 8 V -1 09/04/24, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64787

  18. core-ci voted on patch set 9 V -1 09/04/24, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64788

  19. core-ci voted on patch set 10 V -1 09/04/24, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64789

  20. Ayke Halder commented on patch set 10 09/04/24, 16:26

    Open for thorough review now. I have split up the change, so this one becomes `multi-record-selection` only.

    SelectCheckBoxElement.php:317 Reply

    Done

    SelectCheckBoxElement.php:317 Reply

    Done
  21. Ayke Halder uploaded patch set 11 V -1 09/04/24, 16:27

  22. core-ci voted on patch set 11 V +1 09/04/24, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64791

  23. Lina Wolf commented on patch set 11 CR +1 V +1 09/06/24, 14:24

    Code looks good and works on my machine
  24. Benjamin Kott voted on patch set 11 CR +2 V +2 09/10/24, 09:23

  25. Benjamin Kott merged patch set 12 09/10/24, 09:23