Review main Merged

85733[BUGFIX] Extend exceptions thrown by Guzzle (`TransferException`)

TYPO3com CR +2 V +2 Easy +2 −2 updated 08/27/24, 19:10

Commit message

In `getUrl()` only a `\GuzzleHttp\Exception\RequestException` is
caught. This piece of code exists since April 20, 2016.

At that time `ConnectException` and `RequestException` were not yet
separated in Guzzle. But that changed in January 2020 and since then,
they both extend `TransferException`.

Thus, now `TransferException` is caught, which includes errorhandling
for both a `RequestException` + `ConnectException`, see [1].

[1] https://github.com/guzzle/guzzle/blob/7.9.2/UPGRADING.md?plain=1#L22

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 1320

  1. TYPO3com uploaded patch set 1 08/22/24, 15:36

  2. core-ci voted on patch set 1 V +1 08/22/24, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63998

  3. Garvin Hicking updated the commit message in patch set 2 V +1 08/22/24, 15:49

  4. Garvin Hicking updated the commit message in patch set 3 08/22/24, 15:55

  5. core-ci voted on patch set 2 V +1 08/22/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63999

  6. core-ci voted on patch set 3 V +1 08/22/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64000

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 08/22/24, 19:39

  8. Garvin Hicking commented on patch set 3 08/23/24, 09:02

    Reply

    (Also, should this be backported to v12?)
  9. Stefan Bürk commented on patch set 3 08/27/24, 18:36

    Reply

    Thanks Garvin for your comments. From my point of view, the handling code for the linkvalidator implementation tests on the two specific exception which shares now the same parent (instead one extending the other). IMO I would not change that at this place as it makes cleare to handly only these two specific transfer execption types and report it in a specific way. The second link reagarding the general guzzle tests are unrelated and also tests on the concrete exceptions for now. This patch is is fine in the current form. Do you aggree ?
  10. Garvin Hicking commented on patch set 3 CR +1 V +1 08/27/24, 18:39

    Reply

    Agreed
  11. Stefan Bürk updated the commit message in patch set 4 CR +1 V +1 08/27/24, 18:39

  12. Stefan Bürk updated the commit message in patch set 5 08/27/24, 18:40

  13. core-ci voted on patch set 4 V +1 08/27/24, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64351

  14. core-ci voted on patch set 5 V -1 08/27/24, 18:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64354

  15. Stefan Bürk voted on patch set 5 CR +2 V +2 08/27/24, 19:04

  16. Stefan Bürk voted on patch set 5 CR +1 V +1 08/27/24, 19:04

  17. core-ci voted on patch set 5 V +1 08/27/24, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64354

  18. Stefan Bürk voted on patch set 5 CR +2 V +2 08/27/24, 19:09

  19. Stefan Bürk merged patch set 6 08/27/24, 19:10