85733[BUGFIX] Extend exceptions thrown by Guzzle (`TransferException`)
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
-
Verified V +2 Done
- Stefan Bürk +2
- core-ci +1 CI
Issues 1
Files 1
Review log 1320
-
TYPO3com uploaded patch set 1 08/22/24, 15:36
-
core-ci voted on patch set 1 V +1 08/22/24, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63998
-
Garvin Hicking updated the commit message in patch set 2
V +108/22/24, 15:49 -
Garvin Hicking updated the commit message in patch set 3 08/22/24, 15:55
-
core-ci voted on patch set 2 V +1 08/22/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63999
-
core-ci voted on patch set 3 V +1 08/22/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64000
-
Stefan Bürk voted on patch set 3 CR +1 V +1 08/22/24, 19:39
-
Garvin Hicking commented on patch set 3 08/23/24, 09:01
Maybe you could also look at: https://github.com/TYPO3/typo3/blob/b15ef343b9a168dbe88c4cac64550a2bc84b323d/typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php#L225 where this could probably now be unified, too? If I understnad correctly, https://github.com/TYPO3/typo3/blob/5043d3cb4d6e3069dd1a5cd4c25c9802dad855fd/typo3/sysext/core/Tests/Unit/Http/ClientTest.php#L23 does not need adoption for the tests? BTW, the following places already use TransferException, too: https://github.com/TYPO3/typo3/blob/18341643910c493198a29171ee1b6d2cd892abea/typo3/sysext/install/Classes/SystemEnvironment/ServerResponse/ServerResponseCheck.php#L233 https://github.com/TYPO3/typo3/blob/e50a374c495adbbbda818772a0adc2fd9acb3801/typo3/sysext/extensionmanager/Classes/Service/ComposerManifestProposalGenerator.php#L70 -
Garvin Hicking commented on patch set 3 08/23/24, 09:02
Reply
(Also, should this be backported to v12?) -
Stefan Bürk commented on patch set 3 08/27/24, 18:36
Reply
Thanks Garvin for your comments. From my point of view, the handling code for the linkvalidator implementation tests on the two specific exception which shares now the same parent (instead one extending the other). IMO I would not change that at this place as it makes cleare to handly only these two specific transfer execption types and report it in a specific way. The second link reagarding the general guzzle tests are unrelated and also tests on the concrete exceptions for now. This patch is is fine in the current form. Do you aggree ? -
Garvin Hicking commented on patch set 3 CR +1 V +1 08/27/24, 18:39
Reply
Agreed -
Stefan Bürk updated the commit message in patch set 4
CR +1V +108/27/24, 18:39 -
Stefan Bürk updated the commit message in patch set 5 08/27/24, 18:40
-
core-ci voted on patch set 4 V +1 08/27/24, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64351
-
core-ci voted on patch set 5 V -1 08/27/24, 18:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64354
-
Stefan Bürk voted on patch set 5 CR +2 V +2 08/27/24, 19:04
-
Stefan Bürk voted on patch set 5 CR +1 V +1 08/27/24, 19:04
-
core-ci voted on patch set 5 V +1 08/27/24, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64354
-
Stefan Bürk voted on patch set 5 CR +2 V +2 08/27/24, 19:09
-
Stefan Bürk merged patch set 6 08/27/24, 19:10