Review main Merged

85734[TASK] Close any open modal in InstallTool Cest tear-down

Ayke Halder CR +2 V +2 Easy +14 −26 updated 01/13/25, 10:43

Commit message

This closes any open modal in InstallTool Cest tear-down.
Thereby especially the click on 'logout' in tear-down will always work.
A modal might stay open in case the preceding test fails midway.

This makes it unnecessary to close the modal in the test-cases
itselves.

Otherwise the error reporting for the non-working click on 'logout'
might overlay the actual error.

This depends on `step_decorators: \Codeception\Step\TryTo` which is
available in `main` and `13.4`.

This implements `DataProviders` for `Application\SettingsCest`. Thereby
any flash-messages or modals from in between the test-cases are
automatically closed via `_before`/`_after`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2035

Show 610 earlier messages
  1. Ayke Halder uploaded patch set 1 08/22/24, 15:57

  2. core-ci voted on patch set 1 V -1 08/22/24, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64001

  3. Ayke Halder uploaded patch set 2 V -1 08/22/24, 16:12

  4. Ayke Halder uploaded patch set 3 08/22/24, 16:14

  5. core-ci voted on patch set 2 V +1 08/22/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64002

  6. Ayke Halder updated the commit message in patch set 4 08/22/24, 16:18

  7. core-ci voted on patch set 3 V +1 08/22/24, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64003

  8. core-ci voted on patch set 4 V +1 08/22/24, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64004

  9. Benni Mack updated the commit message in patch set 5 V +1 10/18/24, 13:43

  10. Benni Mack rebased onto patch set 6 11/15/24, 08:38

  1. core-ci voted on patch set 6 V +1 11/15/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69461

  2. Oli Bartsch voted on patch set 6 CR +1 V +1 11/15/24, 13:24

  3. Oli Bartsch uploaded patch set 7 CR +1 V +1 11/15/24, 13:39

  4. core-ci voted on patch set 7 V -1 11/15/24, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69484

  5. Ayke Halder uploaded patch set 8 V -1 11/15/24, 21:32

  6. core-ci voted on patch set 8 V -1 11/15/24, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69502

  7. Ayke Halder uploaded patch set 9 V -1 11/15/24, 21:49

  8. core-ci voted on patch set 9 V -1 11/15/24, 21:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69503

  9. Ayke Halder uploaded patch set 10 V -1 11/15/24, 22:05

  10. core-ci voted on patch set 10 V -1 11/15/24, 22:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69504

  11. Ayke Halder uploaded patch set 11 V -1 11/15/24, 22:20

  12. core-ci voted on patch set 11 V -1 11/15/24, 22:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69507

  13. Ayke Halder uploaded patch set 12 V -1 11/15/24, 23:16

  14. core-ci voted on patch set 12 V -1 11/15/24, 23:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69511

  15. Ayke Halder uploaded patch set 13 V -1 11/15/24, 23:29

  16. core-ci voted on patch set 13 V -1 11/15/24, 23:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69512

  17. Oli Bartsch uploaded patch set 14 V -1 01/13/25, 09:04

  18. core-ci voted on patch set 14 V -1 01/13/25, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72295

  19. Oli Bartsch uploaded patch set 15 V -1 01/13/25, 09:43

  20. core-ci voted on patch set 15 V -1 01/13/25, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72298

  21. Oli Bartsch uploaded patch set 16 V -1 01/13/25, 09:58

  22. core-ci voted on patch set 16 V +1 01/13/25, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72302

  23. Oli Bartsch voted on patch set 16 CR +1 V +1 01/13/25, 10:22

  24. Benni Mack voted on patch set 16 CR +2 V +2 01/13/25, 10:43

  25. Benni Mack merged patch set 17 01/13/25, 10:43