85735[FEATURE] Implement and use a core ViewFactoryInterface
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Anja Leichsenring +1
- Simon Praetorius +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Anja Leichsenring +1
- Simon Praetorius +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 4
Files 53
- typo3/sysext/adminpanel/Classes/Controller/MainController.php+23 −7
- typo3/sysext/adminpanel/Classes/ModuleApi/AbstractModule.php+4 −0
- typo3/sysext/adminpanel/Classes/Modules/Debug/Events.php+14 −6
- typo3/sysext/adminpanel/Classes/Modules/Debug/Log.php+23 −14
- typo3/sysext/adminpanel/Classes/Modules/Debug/PageTitle.php+9 −5
- typo3/sysext/adminpanel/Classes/Modules/Debug/QueryInformation.php+9 −5
- typo3/sysext/adminpanel/Classes/Modules/Info/GeneralInformation.php+14 −6
- typo3/sysext/adminpanel/Classes/Modules/Info/PhpInformation.php+10 −8
- typo3/sysext/adminpanel/Classes/Modules/Info/RequestInformation.php+11 −9
- typo3/sysext/adminpanel/Classes/Modules/Info/UserIntInformation.php+10 −8
- typo3/sysext/adminpanel/Classes/Modules/TsDebug/TypoScriptWaterfall.php+17 −15
- typo3/sysext/adminpanel/Classes/Modules/CacheModule.php+13 −6
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php+13 −11
- typo3/sysext/adminpanel/Tests/Unit/Modules/PreviewModuleTest.php+12 −2
- typo3/sysext/backend/Classes/Controller/LoginController.php+46 −17
- typo3/sysext/backend/Classes/LoginProvider/Event/ModifyPageLayoutOnLoginProviderSelectionEvent.php+31 −3
- typo3/sysext/backend/Classes/LoginProvider/LoginProviderInterface.php+9 −4
- typo3/sysext/backend/Classes/LoginProvider/UsernamePasswordLoginProvider.php+21 −9
- typo3/sysext/backend/Classes/Preview/FluidBasedContentPreviewRenderer.php+18 −14
- typo3/sysext/backend/Classes/View/BackendViewFactory.php+1 −0
Show 33 more files
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/RecoveryCodesProvider.php+66 −58
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/TotpProvider.php+54 −77
- typo3/sysext/core/Classes/Controller/ErrorPageController.php+27 −42
- typo3/sysext/core/Classes/Error/PageErrorHandler/FluidPageErrorHandler.php+35 −30
- typo3/sysext/core/Classes/Mail/FluidEmail.php+35 −12
- typo3/sysext/core/Classes/View/FluidViewAdapter.php10+51 −0
- typo3/sysext/core/Classes/View/FluidViewFactory.phpnew+62 −0
- typo3/sysext/core/Classes/View/ViewFactoryData.phpnew+43 −0
- typo3/sysext/core/Classes/View/ViewFactoryInterface.phpnew+30 −0
- typo3/sysext/core/Documentation/Changelog/13.1/Feature-103504-NewContentObjectPageView.rst3+6 −9
- typo3/sysext/core/Documentation/Changelog/13.3/Deprecation-104764-FluidTemplatePaths-fillDefaultsByPackageName.rst+3 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Deprecation-104773-CustomFluidViewsAndExtbase.rst4new+51 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Deprecation-104773-ExtbackendLoginProviderInterfaceChanges.rst2new+59 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104773-GenericViewFactory.rst10new+60 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php9+83 −30
- typo3/sysext/extbase/Classes/Mvc/View/GenericViewResolver.php+1 −0
- typo3/sysext/extbase/Classes/Mvc/View/ViewResolverInterface.php+1 −0
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+1 −2
- typo3/sysext/fluid/Classes/View/AbstractTemplateView.php+7 −0
- typo3/sysext/fluid/Classes/View/StandaloneView.php+2 −0
- typo3/sysext/fluid/Classes/View/TemplateView.php+2 −0
- typo3/sysext/form/Classes/Domain/Finishers/ConfirmationFinisher.php+41 −68
- typo3/sysext/form/Classes/Domain/Renderer/FluidFormRenderer.php+28 −35
- typo3/sysext/form/Configuration/Yaml/Finishers/Confirmation.yaml+10 −0
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/Confirmation.rst+4 −0
- typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php+96 −155
- typo3/sysext/frontend/Classes/ContentObject/PageViewContentObject.php+40 −91
- typo3/sysext/frontend/Tests/Functional/ContentObject/PageViewContentObjectTest.php+6 −42
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Configuration/TypoScript/plain.typoscript+0 −5
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/templates_in_lowercase/layouts/Default.htmldeleted+0 −9
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/templates_in_lowercase/pages/Standard.htmldeleted+0 −6
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+20 −0
- typo3/sysext/seo/Classes/XmlSitemap/XmlSitemapRenderer.php+18 −15
Review log 81143
Show 61118 earlier messages
-
Christian Kuhn uploaded patch set 1 08/22/24, 18:12
-
core-ci voted on patch set 1 V +1 08/22/24, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64006
-
Christian Kuhn uploaded patch set 2
V +108/22/24, 19:01 -
core-ci voted on patch set 2 V +1 08/22/24, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64007
-
Christian Kuhn rebased onto patch set 3
V +108/22/24, 21:41 -
core-ci voted on patch set 3 V +1 08/22/24, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64023
-
Christian Kuhn uploaded patch set 4
V +108/23/24, 09:37 -
core-ci voted on patch set 4 V -1 08/23/24, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64057
-
Christian Kuhn uploaded patch set 5
V -108/24/24, 17:58 -
core-ci voted on patch set 5 V +1 08/24/24, 18:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64129
-
Christian Kuhn uploaded patch set 6
V +108/24/24, 21:51 -
core-ci voted on patch set 6 V +1 08/24/24, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64135
-
Christian Kuhn uploaded patch set 7
V +108/24/24, 23:00 -
core-ci voted on patch set 7 V +1 08/24/24, 23:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64136
-
Christian Kuhn uploaded patch set 8
V +108/25/24, 12:33 -
core-ci voted on patch set 8 V +1 08/25/24, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64153
-
Christian Kuhn uploaded patch set 9
V +108/25/24, 13:01 -
core-ci voted on patch set 9 V -1 08/25/24, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64154
-
Christian Kuhn uploaded patch set 10
V -108/25/24, 13:30 -
core-ci voted on patch set 10 V +1 08/25/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64155
-
Christian Kuhn uploaded patch set 11
V +108/25/24, 14:53 -
core-ci voted on patch set 11 V +1 08/25/24, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64158
-
Christian Kuhn uploaded patch set 12
V +108/25/24, 16:16 -
core-ci voted on patch set 12 V +1 08/25/24, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64159
-
Christian Kuhn uploaded patch set 13
V +108/26/24, 09:21 -
core-ci voted on patch set 13 V -1 08/26/24, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64187
-
Christian Kuhn uploaded patch set 14
V -108/26/24, 14:14 -
core-ci voted on patch set 14 V -1 08/26/24, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64209
-
Christian Kuhn uploaded patch set 15
V -108/26/24, 14:35 -
core-ci voted on patch set 15 V +1 08/26/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64215
-
Christian Kuhn uploaded patch set 16
V +108/26/24, 15:40 -
core-ci voted on patch set 16 V -1 08/26/24, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64223
-
Christian Kuhn uploaded patch set 17
V -108/26/24, 18:02 -
core-ci voted on patch set 17 V +1 08/26/24, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64240
-
Christian Kuhn uploaded patch set 18
V +108/26/24, 19:48 -
core-ci voted on patch set 18 V -1 08/26/24, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64250
-
Christian Kuhn uploaded patch set 19
V -108/26/24, 20:06 -
core-ci voted on patch set 19 V +1 08/26/24, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64251
-
Christian Kuhn uploaded patch set 20
V +108/26/24, 20:48 -
core-ci voted on patch set 20 V -1 08/26/24, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64252
-
Christian Kuhn uploaded patch set 21
V -108/26/24, 20:57 -
core-ci voted on patch set 21 V +1 08/26/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64253
-
Christian Kuhn uploaded patch set 22
V +108/27/24, 09:57 -
core-ci voted on patch set 22 V +1 08/27/24, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64286
-
Christian Kuhn uploaded patch set 23
V +108/27/24, 10:53 -
core-ci voted on patch set 23 V +1 08/27/24, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64293
-
Christian Kuhn uploaded patch set 24
V +108/27/24, 11:28 -
core-ci voted on patch set 24 V -1 08/27/24, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64296
-
core-ci commented on patch set 24 08/27/24, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64296
-
Christian Kuhn uploaded patch set 25
V -108/27/24, 12:04 -
core-ci voted on patch set 25 V +1 08/27/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64300
-
Christian Kuhn uploaded patch set 26
V +108/27/24, 12:16 -
core-ci voted on patch set 26 V -1 08/27/24, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64304
-
core-ci voted on patch set 26 V +1 08/27/24, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64304
-
Christian Kuhn uploaded patch set 27
V +108/27/24, 14:16 -
core-ci voted on patch set 27 V +1 08/27/24, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64325
-
Christian Kuhn uploaded patch set 28
V +108/27/24, 15:38 -
core-ci voted on patch set 28 V -1 08/27/24, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64335
-
Christian Kuhn uploaded patch set 29
V -108/27/24, 16:07 -
core-ci voted on patch set 29 V +1 08/27/24, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64338
-
Christian Kuhn uploaded patch set 30
V +108/27/24, 16:35 -
core-ci voted on patch set 30 V -1 08/27/24, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64340
-
Christian Kuhn uploaded patch set 31
V -108/27/24, 17:11 -
Christian Kuhn uploaded patch set 32 08/27/24, 17:13
-
core-ci voted on patch set 31 V -1 08/27/24, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64341
-
core-ci voted on patch set 32 V +1 08/27/24, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64342
-
Christian Kuhn uploaded patch set 33
V +108/27/24, 17:50 -
core-ci voted on patch set 33 V +1 08/27/24, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64344
-
Christian Kuhn uploaded patch set 34
V +108/27/24, 18:09 -
core-ci voted on patch set 34 V +1 08/27/24, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64347
-
Christian Kuhn uploaded patch set 35
V +108/27/24, 18:50 -
core-ci voted on patch set 35 V +1 08/27/24, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64355
-
Christian Kuhn rebased onto patch set 36
V +108/28/24, 08:38 -
Christian Kuhn rebased onto patch set 37 08/28/24, 08:38
-
core-ci voted on patch set 37 V +1 08/28/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64392
-
core-ci voted on patch set 36 V +1 08/28/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64391
-
Christian Kuhn uploaded patch set 38
V +108/28/24, 10:07 -
core-ci voted on patch set 38 V +1 08/28/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64404
-
Christian Kuhn uploaded patch set 39
V +108/28/24, 12:52 -
core-ci voted on patch set 39 V +1 08/28/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64419
-
Christian Kuhn rebased onto patch set 40
V +108/28/24, 14:43 -
Christian Kuhn uploaded patch set 41 08/28/24, 14:46
-
core-ci voted on patch set 40 V +1 08/28/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64426
-
core-ci voted on patch set 41 V +1 08/28/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64427
-
Christian Kuhn uploaded patch set 42
V +108/28/24, 16:13 -
core-ci voted on patch set 42 V -1 08/28/24, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64432
-
Christian Kuhn uploaded patch set 43
V -108/28/24, 16:24 -
core-ci voted on patch set 43 V +1 08/28/24, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64433
-
Christian Kuhn rebased onto patch set 44
V +108/28/24, 21:30 -
core-ci voted on patch set 44 V +1 08/28/24, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64438
-
Christian Kuhn uploaded patch set 45
V +108/29/24, 09:36 -
core-ci voted on patch set 45 V +1 08/29/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64463
-
Christian Kuhn uploaded patch set 46
V +108/29/24, 10:12 -
core-ci voted on patch set 46 V +1 08/29/24, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64467
-
Christian Kuhn uploaded patch set 47
V +108/29/24, 12:43 -
core-ci voted on patch set 47 V +1 08/29/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64471
-
Christian Kuhn updated the commit message in patch set 48
V +108/29/24, 13:04 -
Christian Kuhn updated the commit message in patch set 49 08/29/24, 13:06
-
Christian Kuhn updated the commit message in patch set 50 08/29/24, 13:15
-
core-ci voted on patch set 48 V +1 08/29/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64472
-
Christian Kuhn uploaded patch set 51 08/29/24, 13:24
-
core-ci voted on patch set 50 V +1 08/29/24, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64474
-
core-ci voted on patch set 49 V +1 08/29/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64473
-
core-ci voted on patch set 51 V +1 08/29/24, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64475
-
Christian Kuhn uploaded patch set 52
V +108/29/24, 13:44 -
Christian Kuhn uploaded patch set 53 08/29/24, 13:46
-
core-ci voted on patch set 52 V +1 08/29/24, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64476
-
core-ci voted on patch set 53 V -1 08/29/24, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64477
-
Christian Kuhn uploaded patch set 54
V -108/29/24, 14:57 -
core-ci voted on patch set 54 V -1 08/29/24, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64480
-
core-ci voted on patch set 54 V +1 08/29/24, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64480
-
Stefan Bürk voted on patch set 54 CR +1 08/29/24, 16:22
-
Stefan Bürk commented on patch set 54 V +1 08/29/24, 16:28
Great work (along with the series of pre-patches) !!! Test also to implement a custom ViewFactoryInterface implementation (doing same stuff as the FluidViewFactory - but with a switch to also use injected FluidViewFactory) as a simple test for it. https://gist.github.com/sbuerk/ce546ef807b65b468b6b900b1e182e6d -
Simon Praetorius commented on patch set 54 CR -1 08/29/24, 16:47
FluidViewAdapter.php:128Recommendation missingFluidViewAdapter.php:140Recommendation missingFluidViewAdapter.php:152Recommendation missingFluidViewAdapter.php:164Recommendation missingFluidViewAdapter.php:176Recommendation missingDeprecation-104773-CustomFluidViewsAndExtbase.rst:42create()Deprecation-104773-CustomFluidViewsAndExtbase.rst:48JsonView::classFeature-104773-GenericViewFactory.rst:57$this->viewActionController.php:496I'm not sure if it's wise to differentiate here. If someone extended extbase's JsonView (I have done this in the past, and I think there are blog posts out there recommending it), those views would be treated differently.ActionController.php:549Haven't tested it yet, but I think that this wouldn't cover views in defaultViewObjectName that expect Fluid's configuration set on them, like: $defaultViewObjectName = MyExtendedFluidTemplateView::class -
Anja Leichsenring voted on patch set 54 CR +1 V +1 08/29/24, 16:56
-
Stefan Bürk voted on patch set 54 CR 0 V 0 08/29/24, 19:31
-
Garvin Hicking commented on patch set 54 08/29/24, 20:03
Feature-103504-NewContentObjectPageView.rst:133This doesn't really match the "before" notation anymore? What would this variable contain?Deprecation-104773-ExtbackendLoginProviderInterfaceChanges.rst:56instanceFeature-104773-GenericViewFactory.rst:27How about "configured using a dependency injection constructor parameter"?Feature-104773-GenericViewFactory.rst:32.. code-block for matching indentationFeature-104773-GenericViewFactory.rst:45nice use of dto mamed params, I appreciate ;) -
Benni Mack commented on patch set 54 08/29/24, 20:21
Feature-103504-NewContentObjectPageView.rst:133ReplyI would call it `{$plugin.tx_mysite.templatePath}`
-
Anja Leichsenring voted on patch set 54 CR 0 V 0 08/30/24, 05:17
-
Christian Kuhn commented on patch set 54 08/30/24, 07:57
FluidViewAdapter.php:128ReplyDoneFluidViewAdapter.php:140ReplyDoneFluidViewAdapter.php:152ReplyDoneFluidViewAdapter.php:164ReplyDoneFluidViewAdapter.php:176ReplyDoneFeature-103504-NewContentObjectPageView.rst:133ReplyDoneDeprecation-104773-CustomFluidViewsAndExtbase.rst:42ReplyDoneDeprecation-104773-CustomFluidViewsAndExtbase.rst:48ReplyDoneDeprecation-104773-ExtbackendLoginProviderInterfaceChanges.rst:56ReplyDoneFeature-104773-GenericViewFactory.rst:27Replyrephrased.Feature-104773-GenericViewFactory.rst:32Replythat is exactly how hundreds of other places do it.Feature-104773-GenericViewFactory.rst:45Replynamed params is mandatory with DO's.Feature-104773-GenericViewFactory.rst:57ReplyDoneActionController.php:496Replyusing is_a() now.ActionController.php:549Replyyes. that will fall back to the deprecated code below and is deprecated. If you really need something else, your action should take care of it on it's own. The main problem is this awful defaultViewObjectName here, plus the fact the view is "set up" before calling action. It is a "default". If you need to deviate: keep that property null and take care in your action. -
Christian Kuhn uploaded patch set 55
CR -1V +108/30/24, 07:57 -
core-ci voted on patch set 55 V -1 08/30/24, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64515
-
Christian Kuhn uploaded patch set 56
V -108/30/24, 08:32 -
Christian Kuhn uploaded patch set 57 08/30/24, 08:36
-
Christian Kuhn uploaded patch set 58 08/30/24, 08:39
-
core-ci voted on patch set 56 V -1 08/30/24, 08:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64520
-
core-ci voted on patch set 58 V -1 08/30/24, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64522
-
core-ci voted on patch set 57 V -1 08/30/24, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64521
-
Garvin Hicking commented on patch set 58 08/30/24, 08:59
Feature-104773-GenericViewFactory.rst:32ReplyYeah, it's just a recommendation for new content to align this, so when I stumble across it I note it. The docs team is understaffed to review all the old files and use the 'new' syntax. ;-)Feature-104773-GenericViewFactory.rst:45ReplyTIL - figured it was only recommended, not required. That helps me for future reviews, thanks. -
Christian Kuhn uploaded patch set 59
V -108/30/24, 09:16 -
core-ci voted on patch set 59 V +1 08/30/24, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64528
-
Simon Praetorius voted on patch set 59 CR +1 V +1 08/30/24, 09:49
-
Anja Leichsenring voted on patch set 59 CR +1 V +1 08/30/24, 09:50
-
Garvin Hicking voted on patch set 59 CR +1 V +1 08/30/24, 09:51
-
Stefan Bürk voted on patch set 59 CR +1 V +1 08/30/24, 10:11
-
Benni Mack voted on patch set 59 CR +1 V +1 08/30/24, 10:16
-
Christian Kuhn voted on patch set 59 CR +2 V +2 08/30/24, 10:16
-
Christian Kuhn merged patch set 60 08/30/24, 10:19
-
Benjamin Franzke commented on patch set 60 09/02/24, 07:53
ActionController.php:97Hey, this is a breaking change if a controller overwrites the `defaultViewObjectName` via: ``` protected string $defaultViewObjectName = JsonView::class; ``` Note: TYPO3 itself did this prior to a pre-patch to this change which was merged one day before this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85822 `BlogController::$defaultViewObjectName` must be `?string` (as in class `TYPO3\CMS\Extbase\Mvc\Controller\ActionController`) This gives a fatal error: > Fatal error: Type of MyNamespace\Controller\MyController::$defaultViewObjectName must be ?string (as in class TYPO3\CMS\Extbase\Mvc\Controller\ActionController) -
Benjamin Franzke commented on patch set 60 09/02/24, 07:58
ActionController.php:97Reply -
Simon Praetorius commented on patch set 60 09/02/24, 08:42
ActionController.php:97ReplyI think we can use an empty string instead of null as default value for the property and adjust the checks accordingly. I can prepare a draft patch for the created forge issue. -
Christian Kuhn commented on patch set 60 09/02/24, 08:43
ActionController.php:97Replyimho not breaking. I'll answer in more detail later -
Christian Kuhn commented on patch set 60 09/09/24, 18:34
ActionController.php:97ReplySee comment on https://forge.typo3.org/issues/104793