Review main Merged

85735[FEATURE] Implement and use a core ViewFactoryInterface

Christian Kuhn CR +2 V +2 Expert +1250 −835 updated 09/09/24, 18:34

Commit message

After a long list of preparation and side patches, this
change introduces a central ext:core ViewFactoryInterface
plus a default implementation for fluid, and rolls it out.

We established a sub section of a generic view for backend
modules with ext:backend BackendViewFactory in TYPO3 v12
already. This worked out well. The patch picks this up
with a global factory interface for all other use
cases that need to deal with views.

This ultimately allows instances to change any view rendered
by any component by configuring the instance to inject a
different ViewFactoryInterface implementation to some
controller and let it return an ext:core ViewInterface that
uses some different view implemenation like Twig or whatever
floats your boat. This is also very helpful for headless
implementations to transparently substitute casual html
rendering with for instance a json result.

The patch decouples fluid much better and obsoletes the custom
fluid view implementations ext:fluid StandaloneView, ext:fluid
TemplateView and their abstract ext:fluid AbstractTemplateView.
The previous ViewResolverInterface of extbase is obsoleted as
well.

The following architectural decisions have been taken:

* ext:core ViewFactoryInterface has the single create() method
  that takes a ViewFactoryData data object to create an ext:core
  ViewInterface based on it.
* ext:core ViewFactoryInterface should be *injected* whenever
  possible to allow instances reconfiguring the injection. Core
  has only a couple of places where this is not possible yet due
  to technical debt. An example is #104724.
* The default injection of ViewFactoryInterface is ext:core
  FluidViewFactory. This returns an instance of the already
  established FluidViewAdapter, which acts as a facade to
  fluid standalone TemplateView. FluidViewAdapter implements
  all the specialities from the now deprecated custom ext:fluid
  view classes, so switching to this implementation within core
  is not considered breaking. Most of those compatibility
  methods are declared deprecated, though. Some are kept
  non-deprecated, due to technical debt in some consumers.
* ext:core ViewFactoryData is a straight data object that is
  supposed to be set up by view consumers. It is about handing
  over the template paths entry points to the factory, requesting
  a preferred format if desired, and handing over PSR-7 request
  if possible.
* The request is actively hand over in ViewFactoryData whenever
  possible within core usages, since it may help custom
  ViewFactoryInterface implementations to take decisions based on
  it: "If that's a ext:news controller action and if request type
  is json, then create my json view, otherwise fall back to default
  fluid view using FluidViewFactory".
* The signature of ext:core ViewFactoryData is still kinda
  tailored towards fluid with the almighty template/layout/partial
  tuple, but it allows the core to go ahead in this area with TYPO3
  v14, to potentially establish a better solution regarding
  template entry points in general.
* Best use of the ViewFactoryData paths entry points tuple are the
  "extension template entry points", namely arrays of
  "EXT:myExt/Resources/Private/Templates",
  "EXT:myExt/Resources/Private/Layouts" and
  "EXT:myExt/Resources/Private/Partials".
  Only ext:form violates this once, which should be ruled out.
* Single view rendering is best called using
  render('path/within/templateRootPath'): This has been established
  with BackendViewFactory for backend modules already, and gives
  the core a good place to kick in automatic path overlay
  handling later. Only extbase and TEMPLATEVIEW violate this at the
  moment, and we will see on how to continue on this.
* In ViewFactoryData, "templatePathAndFilename" is the ugly kid
  in the block, we'll want to get rid of this when a general
  path lookup and overlay solution is established.

The patch essentially adds the ViewFactoryInterface API, adds
the default FluidViewFactory implementation, and changes all
places that instantiated custom fluid view towards the new API.

Notable specialities:

* ext:adminpanel suffers from an architectual flaw that cripples
  DI on sub modules. GU::makeInstance(ViewFactoryInterface::class)
  solves this for now, but a solution should be handled with
  #104724 to allow injection of ViewFactoryInterface.
* ext:backend LoginController follows a weird logic for extensions
  that take over login rendering to have own login fields. This
  needs a bigger overhaul that is out of scope of this patch.
  Since the existing API hard coded type hints for ext:fluid
  StandaloneView, there is currently no other way than mitigating
  this by introducing a new API method and triggering deprecations
  for extension that don't follow.
* The patch reveals architecural flaws when creating emails via the
  FluidEmail construct where 'composition over inheritance' went
  wrong. This needs a redesign, the implementation is currently
  bound to fluid and throws an exception if the view is not an
  instance of FluidViewAdapter
* Similar with FLUIDTEMPLATE content object: This implementation is
  heavily tailored towards fluid. This is ok'ish: When for instance
  a page rendering for 'headless' is called, those FLUIDTEMPLATE
  TypoScript definitions need to be changed to something else using
  TypoScript. The implementation now throws an exception if the view
  factory did not return a FluidViewAdapter view.
* New v13 PAGEVIEW content object is changed to *not* relax on
  upper/lowercase template filenames for now: While we *do* want
  fluid to handle file and path casings more relaxed, this single
  use case is not the way to go. This needs to be solved on a more
  general level that requires more refactoring, find, and lookup
  magic on a lower level. To stay consistent with current fluid
  strategy, we for now remove the "ignore casing" feature of this
  content object, but it will hopefully see a revamp in v14.
* extbase is (guess what?) problematic. The patch switches from
  ext:extbase ViewResolverInterface to ext:core ViewFactoryInterface
  and keeps using ViewResolverInterface as deprecated fallback.
  The extbase abstract ActionController "defaultViewObjectName"
  API is ugly, is a bit more restricted now, and will have to fall
  at some point. In v14, single actions should probably create a
  view explicitely when they need some, using a helper method
  provided by the abstract, or similar. The automagic view
  configuration is of course kept for now, but becomes more and
  more questionable.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Simon Praetorius +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Simon Praetorius +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 53

Show 33 more files

Review log 81143

Show 61118 earlier messages
  1. Christian Kuhn uploaded patch set 1 08/22/24, 18:12

  2. core-ci voted on patch set 1 V +1 08/22/24, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64006

  3. Christian Kuhn uploaded patch set 2 V +1 08/22/24, 19:01

  4. core-ci voted on patch set 2 V +1 08/22/24, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64007

  5. Christian Kuhn rebased onto patch set 3 V +1 08/22/24, 21:41

  6. core-ci voted on patch set 3 V +1 08/22/24, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64023

  7. Christian Kuhn uploaded patch set 4 V +1 08/23/24, 09:37

  8. core-ci voted on patch set 4 V -1 08/23/24, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64057

  9. Christian Kuhn uploaded patch set 5 V -1 08/24/24, 17:58

  10. core-ci voted on patch set 5 V +1 08/24/24, 18:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64129

  11. Christian Kuhn uploaded patch set 6 V +1 08/24/24, 21:51

  12. core-ci voted on patch set 6 V +1 08/24/24, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64135

  13. Christian Kuhn uploaded patch set 7 V +1 08/24/24, 23:00

  14. core-ci voted on patch set 7 V +1 08/24/24, 23:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64136

  15. Christian Kuhn uploaded patch set 8 V +1 08/25/24, 12:33

  16. core-ci voted on patch set 8 V +1 08/25/24, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64153

  17. Christian Kuhn uploaded patch set 9 V +1 08/25/24, 13:01

  18. core-ci voted on patch set 9 V -1 08/25/24, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64154

  19. Christian Kuhn uploaded patch set 10 V -1 08/25/24, 13:30

  20. core-ci voted on patch set 10 V +1 08/25/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64155

  21. Christian Kuhn uploaded patch set 11 V +1 08/25/24, 14:53

  22. core-ci voted on patch set 11 V +1 08/25/24, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64158

  23. Christian Kuhn uploaded patch set 12 V +1 08/25/24, 16:16

  24. core-ci voted on patch set 12 V +1 08/25/24, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64159

  25. Christian Kuhn uploaded patch set 13 V +1 08/26/24, 09:21

  26. core-ci voted on patch set 13 V -1 08/26/24, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64187

  27. Christian Kuhn uploaded patch set 14 V -1 08/26/24, 14:14

  28. core-ci voted on patch set 14 V -1 08/26/24, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64209

  29. Christian Kuhn uploaded patch set 15 V -1 08/26/24, 14:35

  30. core-ci voted on patch set 15 V +1 08/26/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64215

  31. Christian Kuhn uploaded patch set 16 V +1 08/26/24, 15:40

  32. core-ci voted on patch set 16 V -1 08/26/24, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64223

  33. Christian Kuhn uploaded patch set 17 V -1 08/26/24, 18:02

  34. core-ci voted on patch set 17 V +1 08/26/24, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64240

  35. Christian Kuhn uploaded patch set 18 V +1 08/26/24, 19:48

  36. core-ci voted on patch set 18 V -1 08/26/24, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64250

  37. Christian Kuhn uploaded patch set 19 V -1 08/26/24, 20:06

  38. core-ci voted on patch set 19 V +1 08/26/24, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64251

  39. Christian Kuhn uploaded patch set 20 V +1 08/26/24, 20:48

  40. core-ci voted on patch set 20 V -1 08/26/24, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64252

  41. Christian Kuhn uploaded patch set 21 V -1 08/26/24, 20:57

  42. core-ci voted on patch set 21 V +1 08/26/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64253

  43. Christian Kuhn uploaded patch set 22 V +1 08/27/24, 09:57

  44. core-ci voted on patch set 22 V +1 08/27/24, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64286

  45. Christian Kuhn uploaded patch set 23 V +1 08/27/24, 10:53

  46. core-ci voted on patch set 23 V +1 08/27/24, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64293

  47. Christian Kuhn uploaded patch set 24 V +1 08/27/24, 11:28

  48. core-ci voted on patch set 24 V -1 08/27/24, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64296

  49. core-ci commented on patch set 24 08/27/24, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64296

  50. Christian Kuhn uploaded patch set 25 V -1 08/27/24, 12:04

  51. core-ci voted on patch set 25 V +1 08/27/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64300

  52. Christian Kuhn uploaded patch set 26 V +1 08/27/24, 12:16

  53. core-ci voted on patch set 26 V -1 08/27/24, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64304

  54. core-ci voted on patch set 26 V +1 08/27/24, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64304

  55. Christian Kuhn uploaded patch set 27 V +1 08/27/24, 14:16

  56. core-ci voted on patch set 27 V +1 08/27/24, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64325

  57. Christian Kuhn uploaded patch set 28 V +1 08/27/24, 15:38

  58. core-ci voted on patch set 28 V -1 08/27/24, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64335

  59. Christian Kuhn uploaded patch set 29 V -1 08/27/24, 16:07

  60. core-ci voted on patch set 29 V +1 08/27/24, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64338

  61. Christian Kuhn uploaded patch set 30 V +1 08/27/24, 16:35

  62. core-ci voted on patch set 30 V -1 08/27/24, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64340

  63. Christian Kuhn uploaded patch set 31 V -1 08/27/24, 17:11

  64. Christian Kuhn uploaded patch set 32 08/27/24, 17:13

  65. core-ci voted on patch set 31 V -1 08/27/24, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64341

  66. core-ci voted on patch set 32 V +1 08/27/24, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64342

  67. Christian Kuhn uploaded patch set 33 V +1 08/27/24, 17:50

  68. core-ci voted on patch set 33 V +1 08/27/24, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64344

  69. Christian Kuhn uploaded patch set 34 V +1 08/27/24, 18:09

  70. core-ci voted on patch set 34 V +1 08/27/24, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64347

  71. Christian Kuhn uploaded patch set 35 V +1 08/27/24, 18:50

  72. core-ci voted on patch set 35 V +1 08/27/24, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64355

  73. Christian Kuhn rebased onto patch set 36 V +1 08/28/24, 08:38

  74. Christian Kuhn rebased onto patch set 37 08/28/24, 08:38

  75. core-ci voted on patch set 37 V +1 08/28/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64392

  76. core-ci voted on patch set 36 V +1 08/28/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64391

  77. Christian Kuhn uploaded patch set 38 V +1 08/28/24, 10:07

  78. core-ci voted on patch set 38 V +1 08/28/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64404

  79. Christian Kuhn uploaded patch set 39 V +1 08/28/24, 12:52

  80. core-ci voted on patch set 39 V +1 08/28/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64419

  81. Christian Kuhn rebased onto patch set 40 V +1 08/28/24, 14:43

  82. Christian Kuhn uploaded patch set 41 08/28/24, 14:46

  83. core-ci voted on patch set 40 V +1 08/28/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64426

  84. core-ci voted on patch set 41 V +1 08/28/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64427

  85. Christian Kuhn uploaded patch set 42 V +1 08/28/24, 16:13

  86. core-ci voted on patch set 42 V -1 08/28/24, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64432

  87. Christian Kuhn uploaded patch set 43 V -1 08/28/24, 16:24

  88. core-ci voted on patch set 43 V +1 08/28/24, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64433

  89. Christian Kuhn rebased onto patch set 44 V +1 08/28/24, 21:30

  90. core-ci voted on patch set 44 V +1 08/28/24, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64438

  91. Christian Kuhn uploaded patch set 45 V +1 08/29/24, 09:36

  92. core-ci voted on patch set 45 V +1 08/29/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64463

  93. Christian Kuhn uploaded patch set 46 V +1 08/29/24, 10:12

  94. core-ci voted on patch set 46 V +1 08/29/24, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64467

  95. Christian Kuhn uploaded patch set 47 V +1 08/29/24, 12:43

  96. core-ci voted on patch set 47 V +1 08/29/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64471

  97. Christian Kuhn updated the commit message in patch set 48 V +1 08/29/24, 13:04

  98. Christian Kuhn updated the commit message in patch set 49 08/29/24, 13:06

  99. Christian Kuhn updated the commit message in patch set 50 08/29/24, 13:15

  100. core-ci voted on patch set 48 V +1 08/29/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64472

  101. Christian Kuhn uploaded patch set 51 08/29/24, 13:24

  102. core-ci voted on patch set 50 V +1 08/29/24, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64474

  103. core-ci voted on patch set 49 V +1 08/29/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64473

  104. core-ci voted on patch set 51 V +1 08/29/24, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64475

  105. Christian Kuhn uploaded patch set 52 V +1 08/29/24, 13:44

  106. Christian Kuhn uploaded patch set 53 08/29/24, 13:46

  107. core-ci voted on patch set 52 V +1 08/29/24, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64476

  108. core-ci voted on patch set 53 V -1 08/29/24, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64477

  109. Christian Kuhn uploaded patch set 54 V -1 08/29/24, 14:57

  110. core-ci voted on patch set 54 V -1 08/29/24, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64480

  111. core-ci voted on patch set 54 V +1 08/29/24, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64480

  112. Stefan Bürk voted on patch set 54 CR +1 08/29/24, 16:22

  113. Stefan Bürk commented on patch set 54 V +1 08/29/24, 16:28

    Great work (along with the series of pre-patches) !!! Test also to implement a custom ViewFactoryInterface implementation (doing same stuff as the FluidViewFactory - but with a switch to also use injected FluidViewFactory) as a simple test for it. https://gist.github.com/sbuerk/ce546ef807b65b468b6b900b1e182e6d
  114. Simon Praetorius commented on patch set 54 CR -1 08/29/24, 16:47

    FluidViewAdapter.php:128

    Recommendation missing

    FluidViewAdapter.php:140

    Recommendation missing

    FluidViewAdapter.php:152

    Recommendation missing

    FluidViewAdapter.php:164

    Recommendation missing

    FluidViewAdapter.php:176

    Recommendation missing

    Deprecation-104773-CustomFluidViewsAndExtbase.rst:42

    create()

    Deprecation-104773-CustomFluidViewsAndExtbase.rst:48

    JsonView::class

    Feature-104773-GenericViewFactory.rst:57

    $this->view

    ActionController.php:496

    I'm not sure if it's wise to differentiate here. If someone extended extbase's JsonView (I have done this in the past, and I think there are blog posts out there recommending it), those views would be treated differently.

    ActionController.php:549

    Haven't tested it yet, but I think that this wouldn't cover views in defaultViewObjectName that expect Fluid's configuration set on them, like: $defaultViewObjectName = MyExtendedFluidTemplateView::class
  115. Anja Leichsenring voted on patch set 54 CR +1 V +1 08/29/24, 16:56

  116. Stefan Bürk voted on patch set 54 CR 0 V 0 08/29/24, 19:31

  117. Garvin Hicking commented on patch set 54 08/29/24, 20:03

    Feature-103504-NewContentObjectPageView.rst:133

    This doesn't really match the "before" notation anymore? What would this variable contain?

    Deprecation-104773-ExtbackendLoginProviderInterfaceChanges.rst:56

    instance

    Feature-104773-GenericViewFactory.rst:27

    How about "configured using a dependency injection constructor parameter"?

    Feature-104773-GenericViewFactory.rst:32

    .. code-block for matching indentation

    Feature-104773-GenericViewFactory.rst:45

    nice use of dto mamed params, I appreciate ;)
  118. Benni Mack commented on patch set 54 08/29/24, 20:21

    Feature-103504-NewContentObjectPageView.rst:133 Reply

    I would call it `{$plugin.tx_mysite.templatePath}`
  1. Anja Leichsenring voted on patch set 54 CR 0 V 0 08/30/24, 05:17

  2. Christian Kuhn commented on patch set 54 08/30/24, 07:57

    FluidViewAdapter.php:128 Reply

    Done

    FluidViewAdapter.php:140 Reply

    Done

    FluidViewAdapter.php:152 Reply

    Done

    FluidViewAdapter.php:164 Reply

    Done

    FluidViewAdapter.php:176 Reply

    Done

    Feature-103504-NewContentObjectPageView.rst:133 Reply

    Done

    Deprecation-104773-CustomFluidViewsAndExtbase.rst:42 Reply

    Done

    Deprecation-104773-CustomFluidViewsAndExtbase.rst:48 Reply

    Done

    Deprecation-104773-ExtbackendLoginProviderInterfaceChanges.rst:56 Reply

    Done

    Feature-104773-GenericViewFactory.rst:27 Reply

    rephrased.

    Feature-104773-GenericViewFactory.rst:32 Reply

    that is exactly how hundreds of other places do it.

    Feature-104773-GenericViewFactory.rst:45 Reply

    named params is mandatory with DO's.

    Feature-104773-GenericViewFactory.rst:57 Reply

    Done

    ActionController.php:496 Reply

    using is_a() now.

    ActionController.php:549 Reply

    yes. that will fall back to the deprecated code below and is deprecated. If you really need something else, your action should take care of it on it's own. The main problem is this awful defaultViewObjectName here, plus the fact the view is "set up" before calling action. It is a "default". If you need to deviate: keep that property null and take care in your action.
  3. Christian Kuhn uploaded patch set 55 CR -1 V +1 08/30/24, 07:57

  4. core-ci voted on patch set 55 V -1 08/30/24, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64515

  5. Christian Kuhn uploaded patch set 56 V -1 08/30/24, 08:32

  6. Christian Kuhn uploaded patch set 57 08/30/24, 08:36

  7. Christian Kuhn uploaded patch set 58 08/30/24, 08:39

  8. core-ci voted on patch set 56 V -1 08/30/24, 08:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64520

  9. core-ci voted on patch set 58 V -1 08/30/24, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64522

  10. core-ci voted on patch set 57 V -1 08/30/24, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64521

  11. Garvin Hicking commented on patch set 58 08/30/24, 08:59

    Feature-104773-GenericViewFactory.rst:32 Reply

    Yeah, it's just a recommendation for new content to align this, so when I stumble across it I note it. The docs team is understaffed to review all the old files and use the 'new' syntax. ;-)

    Feature-104773-GenericViewFactory.rst:45 Reply

    TIL - figured it was only recommended, not required. That helps me for future reviews, thanks.
  12. Christian Kuhn uploaded patch set 59 V -1 08/30/24, 09:16

  13. core-ci voted on patch set 59 V +1 08/30/24, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64528

  14. Simon Praetorius voted on patch set 59 CR +1 V +1 08/30/24, 09:49

  15. Anja Leichsenring voted on patch set 59 CR +1 V +1 08/30/24, 09:50

  16. Garvin Hicking voted on patch set 59 CR +1 V +1 08/30/24, 09:51

  17. Stefan Bürk voted on patch set 59 CR +1 V +1 08/30/24, 10:11

  18. Benni Mack voted on patch set 59 CR +1 V +1 08/30/24, 10:16

  19. Christian Kuhn voted on patch set 59 CR +2 V +2 08/30/24, 10:16

  20. Christian Kuhn merged patch set 60 08/30/24, 10:19

  21. Benjamin Franzke commented on patch set 60 09/02/24, 07:53

    ActionController.php:97

    Hey, this is a breaking change if a controller overwrites the `defaultViewObjectName` via: ``` protected string $defaultViewObjectName = JsonView::class; ``` Note: TYPO3 itself did this prior to a pre-patch to this change which was merged one day before this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85822 `BlogController::$defaultViewObjectName` must be `?string` (as in class `TYPO3\CMS\Extbase\Mvc\Controller\ActionController`) This gives a fatal error: > Fatal error: Type of MyNamespace\Controller\MyController::$defaultViewObjectName must be ?string (as in class TYPO3\CMS\Extbase\Mvc\Controller\ActionController)
  22. Benjamin Franzke commented on patch set 60 09/02/24, 07:58

    ActionController.php:97 Reply

  23. Simon Praetorius commented on patch set 60 09/02/24, 08:42

    ActionController.php:97 Reply

    I think we can use an empty string instead of null as default value for the property and adjust the checks accordingly. I can prepare a draft patch for the created forge issue.
  24. Christian Kuhn commented on patch set 60 09/02/24, 08:43

    ActionController.php:97 Reply

    imho not breaking. I'll answer in more detail later
  25. Christian Kuhn commented on patch set 60 09/09/24, 18:34

    ActionController.php:97 Reply