Review main Merged

85738[TASK] Avoid FluidViewAdapter as inner view

Simon Praetorius CR +2 V +2 Easy +2 −7 updated 08/23/24, 05:18

Commit message

FluidViewAdapter->setRenderingContext() sets
itself as view for inner renderings.
This was thought to be a good solution to
trigger deprecations for methods of different
view implementions (StandaloneView & friends).
However, custom fluid views are being phased
out, which will then trigger their own
deprecations.
We can thus remove this quirk.
Also, renderPartial() and renderSection() may
return mixed. This was wrong in fluid
standalone as well, and is fixed in there, too.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Praetorius +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Praetorius +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 915

  1. Simon Praetorius uploaded patch set 1 08/22/24, 19:29

  2. core-ci voted on patch set 1 V +1 08/22/24, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64011

  3. Simon Praetorius uploaded patch set 2 V +1 08/22/24, 20:05

  4. core-ci voted on patch set 2 V -1 08/22/24, 20:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64018

  5. Christian Kuhn uploaded patch set 3 V -1 08/22/24, 20:54

  6. core-ci voted on patch set 2 V -1 08/22/24, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64018

  7. core-ci voted on patch set 3 V +1 08/22/24, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64019

  8. Christian Kuhn uploaded patch set 4 V +1 08/22/24, 21:20

  9. Christian Kuhn marked it ready for review 08/22/24, 21:23

  10. Simon Praetorius voted on patch set 4 CR +1 V +1 08/22/24, 21:23

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 08/22/24, 21:24

  12. core-ci voted on patch set 4 V +1 08/22/24, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64021

  13. core-ci commented on patch set 4 08/22/24, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64022

  14. Stefan Bürk voted on patch set 4 CR +2 V +2 08/23/24, 05:17

  15. Stefan Bürk merged patch set 5 08/23/24, 05:18