Review main Merged

85741[TASK] Avoid ext:fluid TemplateView in tests

Christian Kuhn CR +2 V +2 Easy +5 −11 updated 08/23/24, 05:21

Commit message

There is little reason to use ext:fluid
TemplateView instead of fluid standalone
TemplateView in functional tests.
ext:fluid TemplateView is about to be
phased out.
The test switches existing test usages
to use fluid standalone TemplateView.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Praetorius +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 67

  1. Christian Kuhn uploaded patch set 1 08/22/24, 22:30

  2. core-ci voted on patch set 1 V +1 08/22/24, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64025

  3. Simon Praetorius voted on patch set 1 CR +1 V +1 08/22/24, 22:42

  4. Simon Schaufelberger commented on patch set 1 08/22/24, 23:15

    ScriptViewHelperTest.php:48

    why can this new line not just be left there?
  5. Christian Kuhn commented on patch set 1 08/22/24, 23:29

    ScriptViewHelperTest.php:48 Reply

    it makes that tiny method more dense and easier to grasp. personal taste. ymmw. doing such things as drive-by is fine.
  6. Stefan Bürk voted on patch set 1 CR +2 V +2 08/23/24, 05:21

  7. Stefan Bürk merged patch set 2 08/23/24, 05:21