85741[TASK] Avoid ext:fluid TemplateView in tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Simon Praetorius +1
-
Verified V +2 Done
- Stefan Bürk +2
- Simon Praetorius +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+2 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/ScriptViewHelperTest.php2+1 −5
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FeatureViewHelperTest.php+1 −2
- typo3/sysext/fluid/Tests/Functional/ViewhelperLibraryTest.php+1 −1
Review log 67
-
Christian Kuhn uploaded patch set 1 08/22/24, 22:30
-
core-ci voted on patch set 1 V +1 08/22/24, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64025
-
Simon Praetorius voted on patch set 1 CR +1 V +1 08/22/24, 22:42
-
Simon Schaufelberger commented on patch set 1 08/22/24, 23:15
-
Christian Kuhn commented on patch set 1 08/22/24, 23:29
ScriptViewHelperTest.php:48Replyit makes that tiny method more dense and easier to grasp. personal taste. ymmw. doing such things as drive-by is fine. -
Stefan Bürk voted on patch set 1 CR +2 V +2 08/23/24, 05:21
-
Stefan Bürk merged patch set 2 08/23/24, 05:21
ScriptViewHelperTest.php:48