85742[DOCS] Convert EXT:dashboard syntax from options to confvals
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/dashboard/Documentation/Configuration/WidgetGroupCreation.rst+1 −1
- typo3/sysext/dashboard/Documentation/Configuration/WidgetPresets.rst+26 −16
- typo3/sysext/dashboard/Documentation/Configuration/WidgetRegistration.rst6+80 −53
- typo3/sysext/dashboard/Documentation/Developer/AddingButtons.rst+15 −9
- typo3/sysext/dashboard/Documentation/Widgets/Options/RefreshAvailable.rst.txt+7 −4
- typo3/sysext/dashboard/Documentation/Widgets/BarChartWidget.rst5+13 −8
- typo3/sysext/dashboard/Documentation/Widgets/CTAButtonWidget.rst+15 −10
- typo3/sysext/dashboard/Documentation/Widgets/DoughnutChartWidget.rst4+13 −8
- typo3/sysext/dashboard/Documentation/Widgets/ListWidget.rst+6 −3
- typo3/sysext/dashboard/Documentation/Widgets/NumberWithIconWidget.rst4+23 −14
- typo3/sysext/dashboard/Documentation/Widgets/RssWidget.rst2+22 −15
Review log 2638
Show 813 earlier messages
-
Lina Wolf uploaded patch set 1 08/23/24, 02:11
-
core-ci voted on patch set 1 V +1 08/23/24, 02:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64030
-
Garvin Hicking updated the commit message in patch set 2
V +108/23/24, 05:04 -
core-ci voted on patch set 2 V +1 08/23/24, 05:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64041
-
Chris Müller commented on patch set 2 CR -1 08/23/24, 06:24
WidgetRegistration.rst:188As stated above, this is optional, so no ":required:"WidgetRegistration.rst:196As stated above, this is optional, so no ":required:"BarChartWidget.rst:62Above php-short is used, here php, please stay consistent.DoughnutChartWidget.rst:48Sometimes you use php-sort, sometimes php, please stay consistent.DoughnutChartWidget.rst:57here tooNumberWithIconWidget.rst:61e.g. is superfluousNumberWithIconWidget.rst:74Sometimes you use php-class, sometimes php, please stay consistent.RssWidget.rst:87Sometimes you use php-class, sometimes php, please stay consistent. -
Lina Wolf commented on patch set 2 08/23/24, 06:32
BarChartWidget.rst:62ReplyPlease have a look at how the php-short syntax works: https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/Reference/ReStructuredText/Links/Api.html#links-api-short If we fully print out the FQN once in the same context it should be sufficient to mention it by its short name in subsequent mentionings in the same paragraph.DoughnutChartWidget.rst:48ReplySee aboveDoughnutChartWidget.rst:57ReplySee aboveNumberWithIconWidget.rst:74ReplySee aboveRssWidget.rst:87ReplySee above -
Lina Wolf commented on patch set 3
CR -1V +108/23/24, 06:33Published edit on patch set 2. -
Lina Wolf commented on patch set 3 08/23/24, 06:33
WidgetRegistration.rst:180ReplyGood catchWidgetRegistration.rst:188ReplyDoneWidgetRegistration.rst:196ReplyDone -
Lina Wolf commented on patch set 4 08/23/24, 06:34
Published edit on patch set 3. -
Lina Wolf commented on patch set 4 08/23/24, 06:34
NumberWithIconWidget.rst:61ReplyDone -
core-ci voted on patch set 3 V +1 08/23/24, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64047
-
core-ci voted on patch set 4 V -1 08/23/24, 06:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64048
-
core-ci voted on patch set 4 V +1 08/23/24, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64048
-
Chris Müller commented on patch set 4 08/23/24, 07:11
BarChartWidget.rst:62ReplySo, given that example on that page: ChartDataProviderInterface is short, but ButtonProviderInterface uses the FQCN. Why? The ChartDataProviderInterface is not mentioned above with FQCN (when we agree to omit the FQCN on consecutive occurrences. This is inconsistent and as a user I ask myself? Why once with FQCN and once not (for the same structure here). -
Lina Wolf commented on patch set 5
V +108/23/24, 07:16Published edit on patch set 4. -
Lina Wolf commented on patch set 5 08/23/24, 07:16
BarChartWidget.rst:62ReplyYes the first mention should be a full FQN. Fixed it -
core-ci voted on patch set 5 V +1 08/23/24, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64051
-
Garvin Hicking commented on patch set 5 CR +1 V +1 08/26/24, 08:48
This seems fine for me now, @typo3@brotkrueml.dev ? -
Garvin Hicking uploaded patch set 6
CR +1V +108/26/24, 08:48 -
Garvin Hicking voted on patch set 6 CR +1 V +1 08/26/24, 08:49
-
core-ci voted on patch set 6 V +1 08/26/24, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64182
-
Lina Wolf commented on patch set 6 08/26/24, 09:49
BarChartWidget.rst:62ReplyDone -
Garvin Hicking rebased onto patch set 7
CR +1V +108/26/24, 21:11 -
Garvin Hicking voted on patch set 7 CR +1 V +1 08/26/24, 21:12
-
core-ci voted on patch set 7 V -1 08/26/24, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64254
-
core-ci voted on patch set 7 V +1 08/27/24, 05:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64254
-
Chris Müller voted on patch set 7 CR +1 V +1 08/30/24, 18:26
-
Garvin Hicking commented on patch set 7 08/31/24, 08:32
(needs conflict resolving on cherry picks, will do next week) -
Lina Wolf uploaded patch set 8
CR +1V +108/31/24, 11:56 -
Lina Wolf uploaded patch set 9 08/31/24, 12:00
-
core-ci voted on patch set 8 V -1 08/31/24, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64585
-
core-ci voted on patch set 8 V +1 08/31/24, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64585
-
core-ci voted on patch set 9 V +1 08/31/24, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64586
-
Garvin Hicking commented on patch set 9 CR +1 V +1 09/04/24, 14:33
Thanks for cherry-picking; 11.5 is yet open, 12.4+main seems good to me! :) -
Benni Mack voted on patch set 9 CR +1 V +1 09/04/24, 15:03
-
Garvin Hicking voted on patch set 9 CR +2 V +2 09/04/24, 15:12
-
Garvin Hicking merged patch set 10 09/04/24, 15:12
-
Garvin Hicking commented on patch set 10 09/04/24, 15:14
(merge note: will delay 11.5 cherry-pick a bit, but wanted to fix rendering warnings for main+12 at least already)
WidgetRegistration.rst:180