Review main Merged

85745[TASK] Update to CKEditor5 v43

Benjamin Franzke CR +2 V +2 Expert +1010 −931 updated 08/27/24, 08:35

Commit message

Executed commands:
   npm --prefix overrides/ckeditor5 version 43.0.0
   npm install --save ./overrides/ckeditor5 $(
     grep @ckeditor/ package.json | \
     grep -v @ckeditor/ckeditor5-dev-utils | \
     grep -v @ckeditor/ckeditor5-inspector | \
     sed 's/^[^"]*"\([^"]*\)".*/\1@43.0.0/' \
   )
   npm install --save-dev @ckeditor/ckeditor5-dev-utils@42.0.1
   npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 102

Show 82 more files

Review log 911

  1. Benjamin Franzke uploaded patch set 1 08/23/24, 11:58

  2. Benjamin Franzke commented on patch set 1 V -1 08/23/24, 11:58

    Need to verify and evaluate all the breaking changes listed on https://github.com/ckeditor/ckeditor5/releases/tag/v43.0.0
  3. core-ci voted on patch set 1 V -1 08/23/24, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64065

  4. Garvin Hicking commented on patch set 1 08/23/24, 16:42

    Reply

    BTW: We use v41 ATM, and v42 was also available (https://github.com/ckeditor/ckeditor5/releases/tag/v42.0.0) - it doesn't list any relevant changes IMO. Mostly build related (which doesn't seem to affect us) and some popups moved to modals, changes to premium plugins and minor bugfixes. The editor itself seems to work as usual in my instance. Here's my personal "executive summary" of the changelog, I'd say nothing is really something apparently breaking for TYPO3 conventions. ### Merge Fields: https://ckeditor.com/docs/ckeditor5/latest/features/merge-fields.html * Premium feature, paid license * Allows "template" markers (placeholders) to replace dynamic content with * $0.02: Nice feature, but could be done with custom coding too and in TYPO3 we'd do that with custom content plugins. ### Export to word: https://ckeditor.com/docs/ckeditor5/latest/features/converters/export-word.html * Premium feature, paid license * Allow to create docx files from CKEditor content * v1 config deprecation (not breaking yet) * $0.02: Not so useful for TYPO3 context, there we probably want a doc conversion of the whole page, not just a cKEditor element ### More keyboard shortcuts * $0.02: Alright ### Bugfixes * Android IME (dupe chars, reverse writing effects) and Safari improvements (reverse typing after focus change) * UI: selected option in dropdowns (blue background) now are checkbox marks * However: I don't see that reflected?! * Characters UI moved from dropdown to dialog * page break line algorithm, performance++ ### Breaking Changes * UMD renames ckeditor5->CKEDITOR, ckeditor5-premium-features->CKEDITOR_PREMIUM_FEATURES (if I understand properly that is not relevant for us) * Some API change that are not referenced in the Core and IMO unlikely to affect anyone other than CKEditor Plugin developers * config.htmlEmbed.sanitizeHtml deprecated, we don't seem to use it * "Insert Special characters" is now a modal popup, not a dropdown anymore (nice) * Changes in Annotation/TrackChanges plugins (paid license)
  5. core-ci voted on patch set 1 V +1 08/23/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64065

  6. Benjamin Franzke commented on patch set 1 V 0 08/27/24, 07:00

    Reply

    ack, 42 also needed to be considered, but I couldn't find relevant changes either. So I'm fine with this now and therefore prepared the backport.
  7. Andreas Kienast voted on patch set 1 CR +1 V +1 08/27/24, 08:19

  8. Garvin Hicking voted on patch set 1 CR +1 V +1 08/27/24, 08:27

  9. Benni Mack voted on patch set 1 CR +1 V +1 08/27/24, 08:32

  10. Benjamin Franzke voted on patch set 1 CR +2 V +2 08/27/24, 08:35

  11. Benjamin Franzke merged patch set 2 08/27/24, 08:35