Review main Merged

85751[TASK] Remove unused ext:adminpanel template part

Christian Kuhn CR +2 V +2 Easy +4 −17 updated 08/25/24, 10:58

Commit message

Fluid variable {hookObjectModuleContent} is never
assigned. This is dead template code. Remove along
with a label. It looks as if this is dead since
main admin panel rewrite in v9.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 08/24/24, 18:16

  2. Christian Kuhn updated the commit message in patch set 2 08/24/24, 18:17

  3. core-ci voted on patch set 1 V +1 08/24/24, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64130

  4. core-ci voted on patch set 2 V +1 08/24/24, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64131

  5. Jasmina Ließmann voted on patch set 2 CR +1 V +1 08/24/24, 18:32

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 08/24/24, 21:05

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 08/25/24, 10:58

  8. Christian Kuhn merged patch set 3 08/25/24, 10:58