Review 12.4 Merged

85755[DOCS] Fix YAML syntax highlighting in EXT:dashboard examples

Garvin Hicking CR +2 V +2 Hard +205 −201 updated 08/26/24, 16:42

Commit message

This sets the correct code-block caption definitions for the YAML
and PHP code blocks so they will be rendered correctly.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Chris Müller +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Chris Müller +1

Issues 1

Files 9

Review log 1016

  1. Garvin Hicking commented on patch set 1 08/23/24, 17:14

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/dashboard/Documentation/Configuration/WidgetRegistration.rst * typo3/sysext/dashboard/Documentation/Widgets/RssWidget.rst
  2. core-ci voted on patch set 1 V +1 08/23/24, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64095

  3. Chris Müller uploaded patch set 2 V +1 08/24/24, 07:26

  4. Chris Müller uploaded patch set 3 08/24/24, 07:27

  5. Chris Müller uploaded patch set 4 08/24/24, 07:29

  6. core-ci voted on patch set 2 V +1 08/24/24, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64119

  7. core-ci voted on patch set 3 V +1 08/24/24, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64120

  8. core-ci voted on patch set 4 V +1 08/24/24, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64121

  9. Chris Müller uploaded patch set 5 V +1 08/26/24, 16:19

  10. core-ci voted on patch set 5 V +1 08/26/24, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64228

  11. Garvin Hicking commented on patch set 5 CR +1 V +1 08/26/24, 16:30

    This change is ready for review.
  12. Garvin Hicking updated the commit message in patch set 6 CR +1 V +1 08/26/24, 16:32

  13. Chris Müller voted on patch set 6 CR +1 V +1 08/26/24, 16:33

  14. Garvin Hicking voted on patch set 6 CR +2 V +2 08/26/24, 16:36

  15. Garvin Hicking merged patch set 7 08/26/24, 16:36

  16. core-ci voted on patch set 6 V +1 08/26/24, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64232