Review 11.5 Merged

85756[DOCS] Fix YAML syntax highlighting in EXT:dashboard examples

Garvin Hicking CR +2 V +2 Hard +205 −198 updated 08/26/24, 16:45

Commit message

This sets the correct code-block caption definitions for the YAML
and PHP code blocks so they will be rendered correctly.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Chris Müller +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Chris Müller +1

Issues 1

Files 9

Review log 1118

  1. Garvin Hicking commented on patch set 1 08/23/24, 17:14

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/dashboard/Documentation/Configuration/WidgetRegistration.rst * typo3/sysext/dashboard/Documentation/Widgets/BarChartWidget.rst * typo3/sysext/dashboard/Documentation/Widgets/DoughnutChartWidget.rst * typo3/sysext/dashboard/Documentation/Widgets/ListWidget.rst * typo3/sysext/dashboard/Documentation/Widgets/NumberWithIconWidget.rst * typo3/sysext/dashboard/Documentation/Widgets/RssWidget.rst
  2. core-ci voted on patch set 1 V +1 08/23/24, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64096

  3. Chris Müller uploaded patch set 2 V +1 08/24/24, 07:38

  4. Chris Müller uploaded patch set 3 08/24/24, 07:39

  5. Chris Müller uploaded patch set 4 08/24/24, 07:40

  6. Chris Müller uploaded patch set 5 08/24/24, 07:41

  7. core-ci voted on patch set 3 V +1 08/24/24, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64123

  8. core-ci voted on patch set 5 V +1 08/24/24, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64125

  9. core-ci voted on patch set 2 V +1 08/24/24, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64122

  10. core-ci voted on patch set 4 V +1 08/24/24, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64124

  11. Chris Müller uploaded patch set 6 V +1 08/26/24, 16:21

  12. Garvin Hicking commented on patch set 6 CR +1 V +1 08/26/24, 16:31

    This change is ready for review.
  13. Garvin Hicking updated the commit message in patch set 7 CR +1 V +1 08/26/24, 16:32

  14. Chris Müller voted on patch set 7 CR +1 V +1 08/26/24, 16:34

  15. Garvin Hicking voted on patch set 7 CR +2 V +2 08/26/24, 16:35

  16. Garvin Hicking merged patch set 8 08/26/24, 16:36

  17. core-ci voted on patch set 7 V +1 08/26/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64233

  18. core-ci voted on patch set 6 V +1 08/26/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64230