Review 12.4 Merged

85768[BUGFIX] Ensure proper loading order of EXT:seo and EXT:dashboard

Garvin Hicking CR +2 V +2 Easy +5 −3 updated 09/02/24, 14:07

Commit message

With #103034 EXT:styleguide received a dependency on EXT:seo.

This could lead to a situation for classic installations
(non-composer mode) where via `PackageStates.php` the
loading order was changed in a way that loaded
EXT:dashboard before EXT:seo.

This would lead to widgets defined in EXT:seo not
getting displayed in the dashboard, because the registration
would be performed too late.

The easy fix for this is to adjust the file `ext_emconf.php`
of EXT:seo to provide a 'suggest' key for EXT:dashboard.
The expected PackageStates default in the functional tests
are adapted to match that proper order.

In case EXT:seo is enabled, this 'suggest' entry ensures
that EXT:dashboard is loaded before EXT:seo, so that
everything else falls into place.

Please note that for composer installations this suggestion
was already provided.

For classic installations, [1] states:

    For non-Composer installation ("Classic Mode") the
    `ext_emconf.php` file is the source of truth for required
    dependencies and the loading order of active extensions.

NOTE: To fix a possible ordering problem in existing
installations, rebuilding `PackageStates.php` is needed.
This can be done by enabling and disabling EXT:dashboard
for example, through the Extension Manager.

[1] https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.4/Important-95647-ComposerInstallationsAndExtensionUsage.html

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 09/02/24, 13:55

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/02/24, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64633

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 09/02/24, 14:06

  4. Garvin Hicking merged patch set 2 09/02/24, 14:07