85773[WIP][BUGFIX] adminpanel ModuleDataStorageCollection
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 8
- typo3/sysext/adminpanel/Classes/Controller/MainController.php+6 −12
- typo3/sysext/adminpanel/Classes/ModuleApi/AbstractModule.php+2 −2
- typo3/sysext/adminpanel/Classes/ModuleApi/ModuleDataStorageCollection.phpdeleted+0 −40
- typo3/sysext/adminpanel/Classes/ModuleApi/ShortInfoProviderInterface.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/DebugModule.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/InfoModule.php+1 −1
- typo3/sysext/adminpanel/Classes/ViewHelpers/SubModuleRenderViewHelper.php+3 −4
- typo3/sysext/adminpanel/Tests/Unit/Fixtures/MainModuleFixture.php+1 −2
Review log 58
-
Christian Kuhn uploaded patch set 1 08/24/24, 20:43
-
Christian Kuhn updated the commit message in patch set 2 08/24/24, 20:44
-
core-ci voted on patch set 1 V +1 08/24/24, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64133
-
core-ci voted on patch set 2 V +1 08/24/24, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64134
-
Christian Kuhn uploaded patch set 3
V +109/19/24, 23:17 -
core-ci voted on patch set 3 V +1 09/19/24, 23:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66268
-
Christian Kuhn commented on patch set 3 10/13/24, 12:33
we will solve the underlying issue with https://review.typo3.org/c/Packages/TYPO3.CMS/+/86572 for now. we should still get rid of moduleDataStorageCollection, but that is most likely a task for v14. the patch is abondoned for now. -
Christian Kuhn abandoned the change 10/13/24, 12:33