85776[TASK] Rename submodule TypoScript Overview
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TemplateRecordsOverviewController.php+1 −1
- typo3/sysext/tstemplate/Configuration/Backend/Modules.php+1 −1
- typo3/sysext/tstemplate/Resources/Private/Language/locallang.xlf5+2 −2
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_overview.xlfrenamed+8 −5
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateRecordsOverview.html+29 −7
Review log 4364
Show 2639 earlier messages
-
Lina Wolf uploaded patch set 1 08/26/24, 04:02
-
core-ci voted on patch set 1 V -1 08/26/24, 04:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64164
-
Lina Wolf uploaded patch set 2
V -108/26/24, 04:21 -
core-ci voted on patch set 2 V +1 08/26/24, 04:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64169
-
Garvin Hicking commented on patch set 2 08/26/24, 05:42
-
Lina Wolf commented on patch set 2 08/26/24, 05:46
locallang.xlf:28ReplyWe do also call them "TypoScript sets" for example in Edit TypoScript Record -> "Include TypoScript sets", "Loading order of TypoScript sets" etc? -
Lina Wolf commented on patch set 2 08/26/24, 05:48
locallang.xlf:28ReplyI would therefore conclude that a TypoScript set is any meaningfull collection of typoscript be it in a site set, an extension set or a record... -
Garvin Hicking commented on patch set 2 08/26/24, 06:18
locallang.xlf:28ReplyBut these terms apply to the sets, and not to the records? I feel uncertain here, I'd rather avoid "set" for anything that can be sys_template. Waiting for some other feedback. -
Lina Wolf commented on patch set 3
V +108/26/24, 06:31Published edit on patch set 2. -
Lina Wolf commented on patch set 3 08/26/24, 06:32
locallang.xlf:28ReplyTypoScript Overview is probably also sufficient and less misleading. Changed it -
Lina Wolf updated the commit message in patch set 4 08/26/24, 06:32
-
core-ci voted on patch set 4 V +1 08/26/24, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64177
-
core-ci voted on patch set 3 V +1 08/26/24, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64176
-
Garvin Hicking commented on patch set 4 08/26/24, 14:19
locallang_records_overview.xlf:7rmeove "sets" too?locallang_records_overview.xlf:10"provided" instead of "provider"?locallang_records_overview.xlf:13"definition" here instead of "sets"?locallang_records_overview.xlf:19"definitions" here too? -
Lina Wolf commented on patch set 5
V +108/26/24, 14:35Published edit on patch set 4. -
Lina Wolf commented on patch set 6 08/26/24, 14:36
Published edit on patch set 5. -
Lina Wolf commented on patch set 7 08/26/24, 14:37
Published edit on patch set 6. -
Lina Wolf commented on patch set 7 08/26/24, 14:38
locallang_records_overview.xlf:7ReplyDonelocallang_records_overview.xlf:10ReplyI adjusted it, doesn't sound much better, what do you think?locallang_records_overview.xlf:13ReplyDonelocallang_records_overview.xlf:19ReplyDone -
core-ci voted on patch set 5 V -1 08/26/24, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64213
-
core-ci voted on patch set 6 V -1 08/26/24, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64216
-
core-ci voted on patch set 7 V +1 08/26/24, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64217
-
Garvin Hicking commented on patch set 8
V +108/26/24, 15:59Published edit on patch set 7. -
Garvin Hicking commented on patch set 8 08/26/24, 16:01
locallang_records_overview.xlf:10ReplyHow would you feel about: Global overview of all pages with active TypoScript definitions (database records and sets). That would remove a bit of redundancy, keep it in line with the other way of combining "TypoScript records + TypoScript sets = TypoScript definitions", and even explain that this is the sum of all records and sets"? (I hope this is factually correct?) -
core-ci voted on patch set 8 V +1 08/26/24, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64225
-
Lina Wolf commented on patch set 8 08/26/24, 17:25
locallang_records_overview.xlf:10ReplyActually the subpages do have active TypoScript as well, only they are not the root pages for which it is defined? -
Garvin Hicking commented on patch set 8 08/26/24, 17:28
locallang_records_overview.xlf:10ReplyGlobal overview of all pages with active TypoScript definitions (database records and sets). But those pages only inherit from the pages with active definitions; the pages would not have definitions themselves. How about replacing "active" with "individual" or "assigned"? -
Lina Wolf commented on patch set 9
V +108/26/24, 18:22Published edit on patch set 8. -
Lina Wolf commented on patch set 10 08/26/24, 18:22
Published edit on patch set 9. -
Lina Wolf commented on patch set 10 08/26/24, 18:24
locallang_records_overview.xlf:10ReplyI think that is quite clear, changed it. However we should call them Site Sets. sets from within extensions could not assign TypoScript to a site or page -
core-ci voted on patch set 10 V -1 08/26/24, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64242
-
core-ci voted on patch set 9 V -1 08/26/24, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64241
-
core-ci voted on patch set 9 V -1 08/26/24, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64241
-
Lina Wolf commented on patch set 11
V -108/26/24, 18:36Published edit on patch set 10. -
Lina Wolf commented on patch set 12 08/26/24, 18:37
Published edit on patch set 11. -
Garvin Hicking commented on patch set 12 08/26/24, 18:38
locallang_records_overview.xlf:10ReplyI see. We need to write "site sets" instead of "Site Sets" though :) -
Lina Wolf commented on patch set 12 08/26/24, 18:40
locallang_records_overview.xlf:10ReplyWhy? Site Sets is a new concept, therefore a propper noun and they should be written in Capitalized form now. -
core-ci voted on patch set 11 V -1 08/26/24, 18:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64244
-
core-ci voted on patch set 12 V -1 08/26/24, 18:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64245
-
Garvin Hicking commented on patch set 12 08/26/24, 18:45
locallang_records_overview.xlf:10ReplyItms written "site sets" everywhere else, also in its introductory changelog. In all the other patches we merged, it was lowercased. (Personnally I Would Always Uppercase These Terms, but i go for consistency here)
-
Lina Wolf commented on patch set 13
V -108/26/24, 18:47Published edit on patch set 12. -
Lina Wolf commented on patch set 14 08/26/24, 18:47
Published edit on patch set 13. -
core-ci voted on patch set 13 V -1 08/26/24, 18:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64246
-
core-ci voted on patch set 14 V -1 08/26/24, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64247
-
Benjamin Franzke commented on patch set 14 CR -1 08/27/24, 06:31
I like this, but I think we should change it to `typoscript overview` everywhere then, not just labels. Also language labels will not be updated with the current identifiers, so moving `typo3/sysext/tstemplate/Resources/Private/Language/locallang_records_overview.xlf` to `typo3/sysext/tstemplate/Resources/Private/Language/locallang_overview.xlf` will help with providing v12 and v13 compatible translations. -
Lina Wolf commented on patch set 14 08/27/24, 06:40
Reply
Does that mean you would also rename the controller, the template etc? That would be a breaking change? For example when the templateAnalyzer was renamed to "Included TypoScript" the key "submodules.option.templateAnalyzer" was also not renamed -
Lina Wolf uploaded patch set 15
CR -1V -108/27/24, 06:51 -
core-ci voted on patch set 15 V +1 08/27/24, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64272
-
Benjamin Franzke uploaded patch set 16
V +108/27/24, 07:08 -
Benjamin Franzke commented on patch set 16 08/27/24, 07:08
Reply
> That would be a breaking change? you mean because of bookmarks? other than that it would not be breaking IMO. Anyway, fine by me as-is. -
core-ci voted on patch set 16 V +1 08/27/24, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64274
-
Lina Wolf uploaded patch set 17
CR +1V +108/27/24, 08:37 -
core-ci voted on patch set 17 V +1 08/27/24, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64279
-
Lina Wolf uploaded patch set 18
V +108/27/24, 08:45 -
Garvin Hicking commented on patch set 17 CR +1 V +1 08/27/24, 08:46
I talked to Lina about the <div> thing in the overview, seems to look good now when multiple root and non-root template records and a site set is present. (Not sure I understand the need for renaming the XLF file, but I'm good either way with this and the terminology) -
Benjamin Franzke uploaded patch set 19 08/27/24, 08:52
-
core-ci voted on patch set 18 V +1 08/27/24, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64281
-
Benjamin Franzke commented on patch set 19 08/27/24, 08:54
Reply
sorry, noticed patchset 18 after pushing 19. but should be fine using tag-based syntax (i know the code afterwards uses inline syntax, but tag-based is really more robust here) -
core-ci voted on patch set 19 V +1 08/27/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64282
-
Lina Wolf commented on patch set 19 08/27/24, 09:16
Too me both versions are fine, yours is better readable. I would however suggest to make them both in the same way to avoid confusion -
Garvin Hicking commented on patch set 20
CR +1V +108/27/24, 11:29Published edit on patch set 19. -
Garvin Hicking commented on patch set 20 CR +1 V +1 08/27/24, 11:30
Sorry for resetting votes, I had to unify this for peace of mind ;) -
core-ci voted on patch set 20 V +1 08/27/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64297
-
Benjamin Franzke voted on patch set 20 CR +2 V +2 08/27/24, 11:58
-
Benjamin Franzke merged patch set 21 08/27/24, 11:58
locallang.xlf:28