Review main Merged

85776[TASK] Rename submodule TypoScript Overview

Lina Wolf CR +2 V +2 Normal +43 −18 updated 08/27/24, 11:58

Commit message

The module "TypoScript Record Overview" also contains site
sets since #103439. The module labels are therefore generalized
into "TypoScript Overview".

Also show which entries are site sets and which are records.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 4364

Show 2639 earlier messages
  1. Lina Wolf uploaded patch set 1 08/26/24, 04:02

  2. core-ci voted on patch set 1 V -1 08/26/24, 04:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64164

  3. Lina Wolf uploaded patch set 2 V -1 08/26/24, 04:21

  4. core-ci voted on patch set 2 V +1 08/26/24, 04:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64169

  5. Garvin Hicking commented on patch set 2 08/26/24, 05:42

    locallang.xlf:28

    Since there are records still, IMO this is misleading. We would need a term that includes both. What about just "TypoScript overview"?!
  6. Lina Wolf commented on patch set 2 08/26/24, 05:46

    locallang.xlf:28 Reply

    We do also call them "TypoScript sets" for example in Edit TypoScript Record -> "Include TypoScript sets", "Loading order of TypoScript sets" etc?
  7. Lina Wolf commented on patch set 2 08/26/24, 05:48

    locallang.xlf:28 Reply

    I would therefore conclude that a TypoScript set is any meaningfull collection of typoscript be it in a site set, an extension set or a record...
  8. Garvin Hicking commented on patch set 2 08/26/24, 06:18

    locallang.xlf:28 Reply

    But these terms apply to the sets, and not to the records? I feel uncertain here, I'd rather avoid "set" for anything that can be sys_template. Waiting for some other feedback.
  9. Lina Wolf commented on patch set 3 V +1 08/26/24, 06:31

    Published edit on patch set 2.
  10. Lina Wolf commented on patch set 3 08/26/24, 06:32

    locallang.xlf:28 Reply

    TypoScript Overview is probably also sufficient and less misleading. Changed it
  11. Lina Wolf updated the commit message in patch set 4 08/26/24, 06:32

  12. core-ci voted on patch set 4 V +1 08/26/24, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64177

  13. core-ci voted on patch set 3 V +1 08/26/24, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64176

  14. Garvin Hicking commented on patch set 4 08/26/24, 14:19

    locallang_records_overview.xlf:7

    rmeove "sets" too?

    locallang_records_overview.xlf:10

    "provided" instead of "provider"?

    locallang_records_overview.xlf:13

    "definition" here instead of "sets"?

    locallang_records_overview.xlf:19

    "definitions" here too?
  15. Lina Wolf commented on patch set 5 V +1 08/26/24, 14:35

    Published edit on patch set 4.
  16. Lina Wolf commented on patch set 6 08/26/24, 14:36

    Published edit on patch set 5.
  17. Lina Wolf commented on patch set 7 08/26/24, 14:37

    Published edit on patch set 6.
  18. Lina Wolf commented on patch set 7 08/26/24, 14:38

    locallang_records_overview.xlf:7 Reply

    Done

    locallang_records_overview.xlf:10 Reply

    I adjusted it, doesn't sound much better, what do you think?

    locallang_records_overview.xlf:13 Reply

    Done

    locallang_records_overview.xlf:19 Reply

    Done
  19. core-ci voted on patch set 5 V -1 08/26/24, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64213

  20. core-ci voted on patch set 6 V -1 08/26/24, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64216

  21. core-ci voted on patch set 7 V +1 08/26/24, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64217

  22. Garvin Hicking commented on patch set 8 V +1 08/26/24, 15:59

    Published edit on patch set 7.
  23. Garvin Hicking commented on patch set 8 08/26/24, 16:01

    locallang_records_overview.xlf:10 Reply

    How would you feel about: Global overview of all pages with active TypoScript definitions (database records and sets). That would remove a bit of redundancy, keep it in line with the other way of combining "TypoScript records + TypoScript sets = TypoScript definitions", and even explain that this is the sum of all records and sets"? (I hope this is factually correct?)
  24. core-ci voted on patch set 8 V +1 08/26/24, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64225

  25. Lina Wolf commented on patch set 8 08/26/24, 17:25

    locallang_records_overview.xlf:10 Reply

    Actually the subpages do have active TypoScript as well, only they are not the root pages for which it is defined?
  26. Garvin Hicking commented on patch set 8 08/26/24, 17:28

    locallang_records_overview.xlf:10 Reply

    Global overview of all pages with active TypoScript definitions (database records and sets). But those pages only inherit from the pages with active definitions; the pages would not have definitions themselves. How about replacing "active" with "individual" or "assigned"?
  27. Lina Wolf commented on patch set 9 V +1 08/26/24, 18:22

    Published edit on patch set 8.
  28. Lina Wolf commented on patch set 10 08/26/24, 18:22

    Published edit on patch set 9.
  29. Lina Wolf commented on patch set 10 08/26/24, 18:24

    locallang_records_overview.xlf:10 Reply

    I think that is quite clear, changed it. However we should call them Site Sets. sets from within extensions could not assign TypoScript to a site or page
  30. core-ci voted on patch set 10 V -1 08/26/24, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64242

  31. core-ci voted on patch set 9 V -1 08/26/24, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64241

  32. core-ci voted on patch set 9 V -1 08/26/24, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64241

  33. Lina Wolf commented on patch set 11 V -1 08/26/24, 18:36

    Published edit on patch set 10.
  34. Lina Wolf commented on patch set 12 08/26/24, 18:37

    Published edit on patch set 11.
  35. Garvin Hicking commented on patch set 12 08/26/24, 18:38

    locallang_records_overview.xlf:10 Reply

    I see. We need to write "site sets" instead of "Site Sets" though :)
  36. Lina Wolf commented on patch set 12 08/26/24, 18:40

    locallang_records_overview.xlf:10 Reply

    Why? Site Sets is a new concept, therefore a propper noun and they should be written in Capitalized form now.
  37. core-ci voted on patch set 11 V -1 08/26/24, 18:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64244

  38. core-ci voted on patch set 12 V -1 08/26/24, 18:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64245

  39. Garvin Hicking commented on patch set 12 08/26/24, 18:45

    locallang_records_overview.xlf:10 Reply

    Itms written "site sets" everywhere else, also in its introductory changelog. In all the other patches we merged, it was lowercased. (Personnally I Would Always Uppercase These Terms, but i go for consistency here)
  1. Lina Wolf commented on patch set 13 V -1 08/26/24, 18:47

    Published edit on patch set 12.
  2. Lina Wolf commented on patch set 14 08/26/24, 18:47

    Published edit on patch set 13.
  3. core-ci voted on patch set 13 V -1 08/26/24, 18:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64246

  4. core-ci voted on patch set 14 V -1 08/26/24, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64247

  5. Benjamin Franzke commented on patch set 14 CR -1 08/27/24, 06:31

    I like this, but I think we should change it to `typoscript overview` everywhere then, not just labels. Also language labels will not be updated with the current identifiers, so moving `typo3/sysext/tstemplate/Resources/Private/Language/locallang_records_overview.xlf` to `typo3/sysext/tstemplate/Resources/Private/Language/locallang_overview.xlf` will help with providing v12 and v13 compatible translations.
  6. Lina Wolf commented on patch set 14 08/27/24, 06:40

    Reply

    Does that mean you would also rename the controller, the template etc? That would be a breaking change? For example when the templateAnalyzer was renamed to "Included TypoScript" the key "submodules.option.templateAnalyzer" was also not renamed
  7. Lina Wolf uploaded patch set 15 CR -1 V -1 08/27/24, 06:51

  8. core-ci voted on patch set 15 V +1 08/27/24, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64272

  9. Benjamin Franzke uploaded patch set 16 V +1 08/27/24, 07:08

  10. Benjamin Franzke commented on patch set 16 08/27/24, 07:08

    Reply

    > That would be a breaking change? you mean because of bookmarks? other than that it would not be breaking IMO. Anyway, fine by me as-is.
  11. core-ci voted on patch set 16 V +1 08/27/24, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64274

  12. Lina Wolf uploaded patch set 17 CR +1 V +1 08/27/24, 08:37

  13. core-ci voted on patch set 17 V +1 08/27/24, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64279

  14. Lina Wolf uploaded patch set 18 V +1 08/27/24, 08:45

  15. Garvin Hicking commented on patch set 17 CR +1 V +1 08/27/24, 08:46

    I talked to Lina about the <div> thing in the overview, seems to look good now when multiple root and non-root template records and a site set is present. (Not sure I understand the need for renaming the XLF file, but I'm good either way with this and the terminology)
  16. Benjamin Franzke uploaded patch set 19 08/27/24, 08:52

  17. core-ci voted on patch set 18 V +1 08/27/24, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64281

  18. Benjamin Franzke commented on patch set 19 08/27/24, 08:54

    Reply

    sorry, noticed patchset 18 after pushing 19. but should be fine using tag-based syntax (i know the code afterwards uses inline syntax, but tag-based is really more robust here)
  19. core-ci voted on patch set 19 V +1 08/27/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64282

  20. Lina Wolf commented on patch set 19 08/27/24, 09:16

    Too me both versions are fine, yours is better readable. I would however suggest to make them both in the same way to avoid confusion
  21. Garvin Hicking commented on patch set 20 CR +1 V +1 08/27/24, 11:29

    Published edit on patch set 19.
  22. Garvin Hicking commented on patch set 20 CR +1 V +1 08/27/24, 11:30

    Sorry for resetting votes, I had to unify this for peace of mind ;)
  23. core-ci voted on patch set 20 V +1 08/27/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64297

  24. Benjamin Franzke voted on patch set 20 CR +2 V +2 08/27/24, 11:58

  25. Benjamin Franzke merged patch set 21 08/27/24, 11:58