Review main Merged

85777[BUGFIX] Fall back to site identifier in TypoScript overview

Lina Wolf CR +2 V +2 Easy +8 −1 updated 08/27/24, 11:34

Commit message

When TypoScript is provided by a site set, not a sys_template record and the site has no "website title" it is currently listed without any label in the "TypoScript records overview". However, the "website title" is not a mandatory field.

Fall back to the site identifier if there is not website title. The identifier is mandatory and unique.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Lina Wolf uploaded patch set 1 08/26/24, 04:16

  2. core-ci voted on patch set 1 V +1 08/26/24, 04:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64168

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 08/26/24, 06:16

  4. Christian Kuhn commented on patch set 1 08/26/24, 12:50

    not sure if this *really* makes sense, we risk having the same title over and over again when sys_template records don't set a title. this also needs to be checked / thought about on what happens with site sets and this module ... should it show those?
  5. Christian Kuhn commented on patch set 1 08/26/24, 12:50

    Reply

    .
  6. Lina Wolf commented on patch set 1 08/26/24, 12:56

    Reply

    This change is only about those sites that have no sys_template record, but those that get their template from the site set typoscript provider. Currently if the site has a website title that one is displayed. When the site has no website title only an icon is displayed, no text. This looks kind of broken. As the site identifier is unique per site and each site has only one root page the same title should only be displayed once
  7. Lina Wolf updated the commit message in patch set 2 CR +1 V +1 08/26/24, 13:01

  8. core-ci voted on patch set 2 V +1 08/26/24, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64201

  9. Garvin Hicking commented on patch set 2 CR +1 V +1 08/27/24, 09:21

    Reply

    I agree with Linas feedback - Maybe you could show a screenshot of this in the issue with before/after to make it easily understandable, and maybe we can clear up the issue?
  10. Christian Kuhn commented on patch set 2 CR +1 08/27/24, 09:33

    Reply

    Done
  11. Lina Wolf commented on patch set 2 08/27/24, 10:23

    I added Screenshots to the issue
  12. Garvin Hicking voted on patch set 2 CR +2 V +2 08/27/24, 11:34

  13. Garvin Hicking merged patch set 3 08/27/24, 11:34