Review main Merged

85779[DOCS] Use createValidator() in ext:form docs

Sébastien Delcroix CR +2 V +2 Easy +1 −1 updated 09/24/24, 05:53

Commit message

Since #96998, there's no more __construct() method more in
extbase validators, thus they can't be instanciated with
options anymore, they have to implement setOptions().

The form extension documentation contained a code example
on how to build forms programmatically which has been updated
to respect this by using createValidator() instead of
addValidator() when setting options.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Mathias Brodala +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1115

  1. Sébastien Delcroix uploaded patch set 1 08/26/24, 08:25

  2. core-ci voted on patch set 1 V +1 08/26/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64181

  3. Mathias Brodala commented on patch set 1 CR -1 08/26/24, 08:43

    Index.rst:252

    This quote must be removed, the options before were correct.
  4. Sébastien Delcroix uploaded patch set 2 CR -1 V +1 08/26/24, 08:49

  5. core-ci voted on patch set 2 V +1 08/26/24, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64183

  6. Mathias Brodala voted on patch set 2 CR +1 V +1 08/26/24, 09:17

  7. Christian Kuhn updated the commit message in patch set 3 CR +1 V +1 08/26/24, 09:22

  8. Christian Kuhn commented on patch set 3 08/26/24, 09:22

    Index.rst:252 Reply

    Done
  9. Christian Kuhn voted on patch set 3 CR +1 V +1 08/26/24, 09:23

  10. core-ci voted on patch set 3 V -1 08/26/24, 09:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64188

  11. core-ci voted on patch set 3 V +1 08/26/24, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64188

  12. Mathias Brodala voted on patch set 3 CR +1 V +1 08/26/24, 10:10

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 08/26/24, 10:19

  14. Christian Kuhn merged patch set 4 08/26/24, 11:04

  15. Sébastien Delcroix commented on patch set 4 09/24/24, 05:53

    Index.rst:247 Unresolved

    Should I replace (in another patch) this one too ? As I said to Mathias on Slack, it's not clear to me which one using (addValidator or createValidator) when there is no option to pass.