85786[TASK] Clean up TcaSchema field types
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benjamin Kott +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 32
- typo3/sysext/core/Classes/Schema/Field/AbstractFieldType.php+6 −0
- typo3/sysext/core/Classes/Schema/Field/CategoryFieldType.php+7 −7
- typo3/sysext/core/Classes/Schema/Field/CheckboxFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/ColorFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/DateTimeFieldType.php+1 −11
- typo3/sysext/core/Classes/Schema/Field/EmailFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/FieldCollection.php+5 −5
- typo3/sysext/core/Classes/Schema/Field/FileFieldType.php+16 −6
- typo3/sysext/core/Classes/Schema/Field/FlexFormFieldType.php+3 −8
- typo3/sysext/core/Classes/Schema/Field/FolderFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/GroupFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/ImageManipulationFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/InlineFieldType.php+2 −7
- typo3/sysext/core/Classes/Schema/Field/InputFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/JsonFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/LanguageFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/LinkFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/NoneFieldType.php+5 −3
- typo3/sysext/core/Classes/Schema/Field/NumberFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/PassthroughFieldType.php+1 −6
Show 12 more files
- typo3/sysext/core/Classes/Schema/Field/PasswordFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/RadioFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/SelectRelationFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/SlugFieldType.php+8 −3
- typo3/sysext/core/Classes/Schema/Field/StaticSelectFieldType.php+11 −3
- typo3/sysext/core/Classes/Schema/Field/TextFieldType.php+1 −6
- typo3/sysext/core/Classes/Schema/Field/UserFieldType.php+3 −3
- typo3/sysext/core/Classes/Schema/Field/UuidFieldType.php+3 −3
- typo3/sysext/core/Classes/Schema/FieldFormat.phpnew+112 −0
- typo3/sysext/core/Classes/Schema/TcaSchema.php+8 −2
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php+13 −1
- typo3/sysext/styleguide/ext_tables.sql+1 −0
Review log 2232
Show 57 earlier messages
-
Oli Bartsch uploaded patch set 1 08/27/24, 09:16
-
Oli Bartsch updated the commit message in patch set 2 08/27/24, 09:17
-
core-ci voted on patch set 2 V -1 08/27/24, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64284
-
core-ci voted on patch set 1 V -1 08/27/24, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64283
-
Benni Mack commented on patch set 2 08/27/24, 09:26
-
Christian Kuhn commented on patch set 2 CR -1 08/27/24, 09:31
i'm in favor of keeping the code duplicated and not trying to abstract this away. -
Christian Kuhn commented on patch set 2 08/27/24, 09:44
Reply
feel free to ignore this comment if both benni and you think this additional abstraction is really helpful. note: cgl wise, i'm very in favor of having all __magic() methods as first methods in classes since those are *important* to immediately see they have some magic fuctionality like __set_state, __construct, __destruct and so on, because those change the "profile" of classes so much. I'd go so far that we should have some cgl check for this to take care that's the case core-wide (other patch, if we decide on this).
-
Oli Bartsch uploaded patch set 3
CR -1V -108/27/24, 10:27 -
core-ci voted on patch set 3 V -1 08/27/24, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64289
-
Oli Bartsch uploaded patch set 4
V -108/27/24, 10:34 -
Oli Bartsch uploaded patch set 5 08/27/24, 10:35
-
Oli Bartsch commented on patch set 5 08/27/24, 10:36
Reply
AcknowledgedAbstractRelationFieldType.php:26ReplyAcknowledged -
core-ci voted on patch set 4 V -1 08/27/24, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64290
-
Oli Bartsch uploaded patch set 6 08/27/24, 10:39
-
core-ci voted on patch set 5 V -1 08/27/24, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64291
-
core-ci voted on patch set 6 V +1 08/27/24, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64292
-
core-ci voted on patch set 5 V +1 08/27/24, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64291
-
Christian Kuhn voted on patch set 6 CR -1 08/27/24, 22:51
-
Christian Kuhn commented on patch set 6 08/27/24, 23:07
RelationalFieldTypeInterface.php:28general rule: keep interfaces composed, not inherited. decoupling over coupling. core examples where we actually removed interface inheritance: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85638/10/typo3/sysext/form/Classes/Mvc/Configuration/ConfigurationManagerInterface.php (recent) https://review.typo3.org/c/Packages/TYPO3.CMS/+/57987 (older) -
Oli Bartsch uploaded patch set 7
CR -1V +108/28/24, 07:48 -
Oli Bartsch commented on patch set 7 08/28/24, 07:49
RelationalFieldTypeInterface.php:28ReplyAcknowledged -
core-ci voted on patch set 7 V +1 08/28/24, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64390
-
Oli Bartsch rebased onto patch set 8
V +109/03/24, 06:21 -
core-ci voted on patch set 8 V +1 09/03/24, 06:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64649
-
Simon Schaufelberger voted on patch set 8 CR +1 09/04/24, 09:47
-
Jochen Roth voted on patch set 8 CR +1 V +1 09/09/24, 09:31
-
Oli Bartsch uploaded patch set 9
CR +1V +109/10/24, 07:32 -
Jochen Roth voted on patch set 9 CR +1 V +1 09/10/24, 07:35
-
core-ci voted on patch set 9 V +1 09/10/24, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65183
-
Benjamin Kott voted on patch set 9 CR +1 V +1 09/10/24, 07:54
-
Oli Bartsch voted on patch set 9 CR +2 V +2 09/10/24, 08:02
-
Oli Bartsch merged patch set 10 09/10/24, 08:02
AbstractRelationFieldType.php:26