Review main Merged

85796[DOCS] Adjust markup and remove duplication from CKEditor5 changelog

Sébastien Delcroix CR +2 V +2 Easy +2 −16 updated 08/27/24, 19:57

Commit message

Adjusted indentation syntax which was breaking the rendering of
feature #96874 changelog entry of the CKEditor 5 documentation.

Removed the duplicated part about "editor.config.stylesSet", too.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Sébastien Delcroix uploaded patch set 1 08/27/24, 15:34

  2. core-ci voted on patch set 1 V -1 08/27/24, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64334

  3. core-ci voted on patch set 1 V +1 08/27/24, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64334

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 08/27/24, 17:25

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 08/27/24, 17:50

  6. Chris Müller commented on patch set 1 CR -1 08/27/24, 18:13

    Feature-96874-CKEditor5.rst:86

    Is the indentation removed by intention? Now we have a bullet point, then a normal paragraph, then again a bullet point?
  7. Chris Müller commented on patch set 1 08/27/24, 18:14

    Feature-96874-CKEditor5.rst:86 Reply

    Okay, one space is missing, you have to use four spaces instead of three, then the rendering should be okay.
  8. Garvin Hicking uploaded patch set 2 CR +1 V +1 08/27/24, 18:19

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 08/27/24, 18:20

  10. Garvin Hicking commented on patch set 2 08/27/24, 18:20

    Feature-96874-CKEditor5.rst:86 Reply

    Good catch, you are right of course - adjusted this.
  11. Stefan Bürk voted on patch set 2 CR +1 V +1 08/27/24, 18:21

  12. core-ci voted on patch set 2 V +1 08/27/24, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64349

  13. Garvin Hicking voted on patch set 2 CR +2 V +2 08/27/24, 19:57

  14. Garvin Hicking merged patch set 3 08/27/24, 19:57