Review main Merged

85801[TASK] Turn a couple of unit tests into functionals

Christian Kuhn CR +2 V +2 Normal +10 −79 updated 08/27/24, 18:50

Commit message

To reduce mocking and GeneralUtility instance
tampering, a couple of error handling related
tests are turned into functional tests.
Also, a data provider case that misuses an
unrelated class is removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Christian Kuhn uploaded patch set 1 08/27/24, 18:39

  2. Nikita Hovratov voted on patch set 1 CR +1 V +1 08/27/24, 18:46

  3. core-ci voted on patch set 1 V +1 08/27/24, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64352

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 08/27/24, 18:48

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 08/27/24, 18:49

  6. Christian Kuhn merged patch set 2 08/27/24, 18:50