Review main Merged

85803[TASK] Remove deprecated "srcsetAttr" in DefaultSanitizerBuilder

Wouter Wolters CR +2 V +2 Easy +0 −1 updated 01/14/25, 16:30

Commit message

\TYPO3\HtmlSanitizer\Builder\CommonBuilder annotates property
srcsetAttr as "@deprecated not used anymore". That's true,
it's only written but never read. It is pointless to set it
in DefaultSanitizerBuilder.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Wouter Wolters uploaded patch set 1 08/28/24, 09:16

  2. core-ci voted on patch set 1 V -1 08/28/24, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64395

  3. core-ci voted on patch set 1 V +1 08/28/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64395

  4. Simon Praetorius commented on patch set 1 09/04/24, 17:20

    Do we need to apply this to v12?
  5. Wouter Wolters commented on patch set 1 09/04/24, 18:56

    Reply

    as v12 uses the same HTML sanitizer version I decided to add this small change also for v12.
  6. Benni Mack updated the commit message in patch set 2 V +1 10/18/24, 13:48

  7. Christian Kuhn uploaded patch set 3 01/14/25, 15:31

  8. Christian Kuhn commented on patch set 3 CR +1 V +1 01/14/25, 15:32

    Reply

    let's not backport this to v12 anymore.
  9. Stefan Bürk voted on patch set 3 CR +1 V +1 01/14/25, 15:36

  10. core-ci voted on patch set 3 V +1 01/14/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72465

  11. Oliver Hader commented on patch set 3 01/14/25, 15:55

    Anybody please create a PR for the upstream html-sanitizer, dropping the property completely? If it is dropped, we can finally be sure it is not used anymore.
  12. Christian Kuhn commented on patch set 3 01/14/25, 16:03

    Reply

    is this considered breaking for typo3/html-sanitizer and thus forces a new major, which may need some branch preparations?
  13. Christian Kuhn commented on patch set 3 01/14/25, 16:14

  14. Christian Kuhn voted on patch set 3 CR +2 V +2 01/14/25, 16:30

  15. Christian Kuhn merged patch set 4 01/14/25, 16:30