Review main Merged

85804[TASK] Replace usage of deprecated constants of PhpParser

Wouter Wolters CR +2 V +2 Easy +3 −3 updated 08/28/24, 10:10

Commit message

In class InterfaceMethodChangedMatcher constants MODIFIER_PUBLIC
and MODIFIER_STATIC are used. Both are deprecated. Use Modifiers::PUBLIC
and Modifiers::STATIC instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Wouter Wolters uploaded patch set 1 08/28/24, 09:28

  2. core-ci voted on patch set 1 V +1 08/28/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64396

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 08/28/24, 09:45

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 08/28/24, 10:10

  5. Christian Kuhn merged patch set 2 08/28/24, 10:10