Review main Merged

85805[BUGFIX] Streamline offsetGet and offsetExist in Record object

Oli Bartsch CR +2 V +2 Easy +17 −2 updated 08/28/24, 13:40

Commit message

Array access of `uid` and `pid` has been enabled, therefore
offsetExist() needs to return TRUE for those fields, too.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Oli Bartsch uploaded patch set 1 08/28/24, 09:33

  2. core-ci voted on patch set 1 V +1 08/28/24, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64397

  3. Benni Mack commented on patch set 1 CR +1 V +1 08/28/24, 10:16

    Can we cover this with a unit test?
  4. Oli Bartsch uploaded patch set 2 CR +1 V +1 08/28/24, 11:27

  5. Oli Bartsch commented on patch set 2 08/28/24, 11:27

    Reply

    Sure, done.
  6. core-ci voted on patch set 2 V +1 08/28/24, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64413

  7. Benni Mack voted on patch set 2 CR +1 V +1 08/28/24, 13:08

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 08/28/24, 13:26

  9. Oli Bartsch voted on patch set 2 CR +2 V +2 08/28/24, 13:40

  10. Oli Bartsch merged patch set 3 08/28/24, 13:40