Review main Merged

85808[BUGFIX] Prevent undefined array key exception in FlexFormValueFormatter

Torben Hansen CR +2 V +2 Easy +2 −2 updated 08/28/24, 10:53

Commit message

The `getProcessedElements` function in `FlexFormValueFormatter`
throws an undefined array key exception, when the given
dataStructure contains a field with a relation table having a
`label_userFunc` and when the given valueStructure does not contain
a value for the field.

This change adds a fallback to an empty string, when
`$valueStructure[$elementKey]['vDEF']` is not set.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Torben Hansen uploaded patch set 1 08/28/24, 10:21

  2. core-ci voted on patch set 1 V +1 08/28/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64406

  3. Christian Kuhn commented on patch set 1 CR +1 V +1 08/28/24, 10:41

    LGTM
  4. Stefan Bürk voted on patch set 1 CR +2 V +2 08/28/24, 10:46

  5. Stefan Bürk merged patch set 2 08/28/24, 10:53