85811[TASK] Streamline extbase data / column mapping
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/core/Classes/DataHandling/RecordFieldTransformer.php+2 −2
- typo3/sysext/core/Classes/Schema/Capability/FieldCapability.php+5 −0
- typo3/sysext/core/Classes/Schema/Capability/SystemInternalFieldCapability.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/DateTimeFieldType.php+3 −1
- typo3/sysext/core/Classes/Schema/RelationshipType.php+6 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMapFactory.php+71 −122
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php3+40 −42
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_data_mapper/Classes/Domain/Model/Example.php+33 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_data_mapper/Configuration/TCA/tx_testdatamapper_domain_model_example.php+18 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/ColumnMapFactoryTest.php+18 −15
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+11 −32
Review log 1321
-
Oli Bartsch uploaded patch set 1 08/28/24, 11:45
-
core-ci voted on patch set 1 V -1 08/28/24, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64414
-
Oli Bartsch uploaded patch set 2
V -109/03/24, 15:10 -
Oli Bartsch uploaded patch set 3 09/03/24, 15:14
-
core-ci voted on patch set 2 V -1 09/03/24, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64675
-
Oli Bartsch uploaded patch set 4 09/03/24, 15:24
-
core-ci voted on patch set 4 V -1 09/03/24, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64677
-
core-ci voted on patch set 3 V -1 09/03/24, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64676
-
core-ci commented on patch set 4 09/03/24, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64677
-
Oli Bartsch uploaded patch set 5
V -109/03/24, 21:12 -
core-ci voted on patch set 5 V +1 09/03/24, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64699
-
Oli Bartsch updated the commit message in patch set 6
V +109/03/24, 21:32 -
core-ci voted on patch set 6 V -1 09/03/24, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64700
-
core-ci voted on patch set 6 V +1 09/04/24, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64700
-
Benni Mack voted on patch set 6 CR +1 V +1 09/04/24, 09:41
-
Stefan Bürk voted on patch set 6 CR +1 V +1 09/04/24, 18:40
-
Oli Bartsch voted on patch set 6 CR +2 V +2 09/05/24, 08:54
-
Oli Bartsch merged patch set 7 09/05/24, 08:54
-
Christian Kuhn commented on patch set 7 12/03/24, 14:03
post -1DataMapFactory.php:230uhm. that's the wrong setter used here ... also in the calls below. -
Christian Kuhn commented on patch set 7 12/03/24, 15:08
DataMapFactory.php:230Reply -
Benni Mack commented on patch set 7 02/18/25, 10:06
DataMapFactory.php:221Unresolvedthis is wrong IMHO, we always have the rootLevel Capability but we used the wrong constants in the Schema API. Will push a followup