Review main Merged

85811[TASK] Streamline extbase data / column mapping

Oli Bartsch CR +2 V +2 Hard +218 −221 updated 02/18/25, 10:06

Commit message

The extbase data and column mapping is now properly
using the TCA schema API. While streamlining the
code some divergences regarding relation handling
have been observed (e.g. use of "maxitems" and
"renderType" options). Those will be tackled
separately, since streamlining this might be
breaking.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1321

  1. Oli Bartsch uploaded patch set 1 08/28/24, 11:45

  2. core-ci voted on patch set 1 V -1 08/28/24, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64414

  3. Oli Bartsch uploaded patch set 2 V -1 09/03/24, 15:10

  4. Oli Bartsch uploaded patch set 3 09/03/24, 15:14

  5. core-ci voted on patch set 2 V -1 09/03/24, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64675

  6. Oli Bartsch uploaded patch set 4 09/03/24, 15:24

  7. core-ci voted on patch set 4 V -1 09/03/24, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64677

  8. core-ci voted on patch set 3 V -1 09/03/24, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64676

  9. core-ci commented on patch set 4 09/03/24, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64677

  10. Oli Bartsch uploaded patch set 5 V -1 09/03/24, 21:12

  11. core-ci voted on patch set 5 V +1 09/03/24, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64699

  12. Oli Bartsch updated the commit message in patch set 6 V +1 09/03/24, 21:32

  13. core-ci voted on patch set 6 V -1 09/03/24, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64700

  14. core-ci voted on patch set 6 V +1 09/04/24, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64700

  15. Benni Mack voted on patch set 6 CR +1 V +1 09/04/24, 09:41

  16. Stefan Bürk voted on patch set 6 CR +1 V +1 09/04/24, 18:40

  17. Oli Bartsch voted on patch set 6 CR +2 V +2 09/05/24, 08:54

  18. Oli Bartsch merged patch set 7 09/05/24, 08:54

  19. Christian Kuhn commented on patch set 7 12/03/24, 14:03

    post -1

    DataMapFactory.php:230

    uhm. that's the wrong setter used here ... also in the calls below.
  20. Christian Kuhn commented on patch set 7 12/03/24, 15:08

  21. Benni Mack commented on patch set 7 02/18/25, 10:06

    DataMapFactory.php:221 Unresolved

    this is wrong IMHO, we always have the rootLevel Capability but we used the wrong constants in the Schema API. Will push a followup